[U-Boot] [PATCH v3 2/3] spi: zynqmp_qspi: Add QSPI driver support for ZynqMP

[Jagan Teki]

On Thu, Oct 20, 2016 at 5:03 PM, S Durga Prasad Paladugu
<durgaprasad.psdp at gmail.com> wrote:
> Hi Jagan,
>
> On Wed, Jul 27, 2016 at 1:28 PM, Jagan Teki <jagannadh.teki at gmail.com>
> wrote:
>>
>> On 19 July 2016 at 14:40, Siva Durga Prasad Paladugu
>> <siva.durga.paladugu at xilinx.com> wrote:
>> > This adds QSPI driver support for ZynqMP platform
>> > This driver supports all spi flash commands in
>> > qspi single mode.
>> >
>> > Signed-off-by: Siva Durga Prasad Paladugu <sivadur at xilinx.com>
>> > ---
>> > Changes for v3:
>> > - None
>> > Changes for v2:
>> > - set no_all_quad as zynqmp qspi
>> >   controller doesnt support it
>> > ---
>> >  drivers/spi/Kconfig       |   9 +
>> >  drivers/spi/Makefile      |   1 +
>> >  drivers/spi/zynqmp_qspi.c | 705
>> > ++++++++++++++++++++++++++++++++++++++++++++++
>> >  3 files changed, 715 insertions(+)
>> >  create mode 100644 drivers/spi/zynqmp_qspi.c
>> >
>> > diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
>> > index aca385d..6814ff9 100644
>> > --- a/drivers/spi/Kconfig
>> > +++ b/drivers/spi/Kconfig
>> > @@ -172,6 +172,15 @@ config ZYNQ_QSPI
>> >           Zynq QSPI IP core. This IP is used to connect the flash in
>> >           4-bit qspi, 8-bit dual stacked and shared 4-bit dual parallel.
>> >
>> > +config ZYNQMP_QSPI
>> > +       bool "ZynqMP QSPI driver"
>> > +       depends on ARCH_ZYNQMP
>> > +       help
>> > +         Enable the ZynqMP Quad-SPI (QSPI) driver. This driver can be
>> > +         used to access the SPI NOR flash on platforms embedding this
>> > +         ZynqMP QSPI IP core. This IP is used to connect the flash in
>> > +         4-bit qspi, 8-bit dual stacked and shared 4-bit dual parallel.
>>
>> If this is the case, spi couldn't be the correct place to handle nor
>> dualness.
>
>
> But i see zynq also added here. If this not the correct place could you
> please point me
> to where this should go.

If you're sure to have this controller with SPI-NOR chips and will
plan to add dual flash features in future then better write it on
mtd/spi/ side (means flash side)

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.