[U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support
Stefano Babic
sbabic at denx.de
Mon Oct 24 11:05:23 CEST 2016
On 24/10/2016 10:54, Jagan Teki wrote:
> Hi Stefano,
>
> On Mon, Oct 24, 2016 at 2:06 PM, Stefano Babic <sbabic at denx.de> wrote:
>> On 24/10/2016 09:53, Jagan Teki wrote:
>>> Hi Stefano,
>>>
>>> On Mon, Oct 17, 2016 at 11:26 AM, Stefano Babic <sbabic at denx.de> wrote:
>>>> Hi Jagan,
>>>>
>>>> On 17/10/2016 05:40, Jagan Teki wrote:
>>>>> Hi Stefano,
>>>>>
>>>>> On Tue, Oct 11, 2016 at 9:00 AM, Jagan Teki <jteki at openedev.com> wrote:
>>>>>> Hi Stefano,
>>>>>>
>>>>>> On Sun, Oct 9, 2016 at 8:15 PM, Jagan Teki <jagannadh.teki at gmail.com> wrote:
>>>>>>> Hi Stefano,
>>>>>>>
>>>>>>> On Sat, Oct 8, 2016 at 6:00 PM, Jagan Teki <jteki at openedev.com> wrote:
>>>>>>>> From: Jagan Teki <jagan at amarulasolutions.com>
>>>>>>>>
>>>>>>>> This series supports Engicam i.CoreM6 QDL modules on top of u-boot-imx/master
>>>>>>>> and test on the respective starter kits as well.
>>>>>>>>
>>>>>>>> Tested both MMC and NAND boot.
>>>>>>>>
>>>>>>>> Changes for v7:
>>>>>>>> - Add patch to CONFIG_DEFAULT_FDT_FILE to defconfigs
>>>>>>>> - Rebase on u-boot-imx/master
>>>>>>>>
>>>>>>>> Changes for v6:
>>>>>>>> - Rebase to u-boot-imx/master
>>>>>>>> - Move few SPL configs to defconfigs
>>>>>>>>
>>>>>>>> Changes for v5:
>>>>>>>> - Add NAND support
>>>>>>>>
>>>>>>>> Changes for v4:
>>>>>>>> - Add 'net: Kconfig: Add FEC_MXC entry' patch
>>>>>>>> - Updated ENV configs along with comments
>>>>>>>> - Restructured configs for more readability
>>>>>>>> - Add CONFIG_ENV_OVERWRITE
>>>>>>>> - Rename icorem6qdl_defconfig with icorem6qdl_mmc_defconfig
>>>>>>>>
>>>>>>>> Changes for v3:
>>>>>>>> - Remove "v2 01/17 imx: iomux-v3: Fix build error with snvs base" patch
>>>>>>>> - Remove 'default n' on Kconfig DEFAULT_FDT_FILE patch
>>>>>>>> - Add minimal devicetree support for Engicam i.CoreM6 QDL
>>>>>>>> - Add is_mx6dl()
>>>>>>>> - Add is_mx6solo()
>>>>>>>> - Use is_mx6dq()
>>>>>>>> - Add last commit sha1 and header in pull devicetree files from Linux
>>>>>>>>
>>>>>>>> Changes for v2:
>>>>>>>> - Make static to local iomux structure in board file
>>>>>>>> - Corrected rowaddr in mx6_ddr3_cfg
>>>>>>>> - Used imx_ddr_size
>>>>>>>> - Add FEC support and tested the same
>>>>>>>> - Add DM_GPIO, DM_MMC support
>>>>>>>> - Add pinctrl support
>>>>>>>> - Add devicetree support
>>>>>>>>
>>>>>>>> Jagan Teki (21):
>>>>>>>> serial: Kconfig: Add MXC_UART entry
>>>>>>>> thermal: Kconfig: Add IMX_THERMAL entry
>>>>>>>> config: Move CONFIG_DEFAULT_FDT_FILE to defconfigs
>>>>>>>> arm: imx: Add Engicam i.CoreM6 QDL Starter Kit initial support
>>>>>>>> net: Kconfig: Add FEC_MXC entry
>>>>>>>> imx6: icorem6: Add ENET support
>>>>>>>> imx: s/docs\/README.imximage/doc\/README.imximage/g
>>>>>>>> arm: dts: Add devicetree for i.MX6DL
>>>>>>>> arm: dts: Add devicetree for i.MX6DQL
>>>>>>>> arm: dts: imx6dl: Add pinctrl defines
>>>>>>>> dt-bindings: clock: imx6qdl: Add clock defines
>>>>>>>> arm: imx6q: Add devicetree support for Engicam i.CoreM6 DualLite/Solo
>>>>>>>> imx6q: icorem6: Enable pinctrl driver
>>>>>>>> engicam: icorem6: Add DM_GPIO, DM_MMC support
>>>>>>>> arm: dts: Add devicetree for i.MX6Q
>>>>>>>> arm: dts: imx6q: Add pinctrl defines
>>>>>>>> arm: imx6q: Add devicetree support for Engicam i.CoreM6 Quad/Dual
>>>>>>>> mtd: nand: Kconfig: Add NAND_MXS entry
>>>>>>>> imx6: icorem6: Add NAND support
>>>>>>>> imx6: icorem6: Enable MTD device support
>>>>>>>> imx6: icorem6: Add default mtd nand partition table
>>>>>>>
>>>>>>> All set now, please do apply.
>>>>>>
>>>>>> Let me know if you still find any issues, otherwise apply this.
>>>>>>
>>>>>
>>>>> Any help?
>>>>
>>>> Sorry, I was last week at ELCE - I will go on with your patches (and the
>>>> other ones left pending) this week.
>>>
>>> Please apply this, I need to rebase on top of tom/master and send few
>>> more series.
>>>
>>
>>
>> Tried again, it does not compile clean.
>> drivers/mmc/fsl_esdhc.c:715:21: error: variable 'esdhc_ops' has
>> initializer but incomplete type
>> static const struct mmc_ops esdhc_ops = {
>> ^
>> drivers/mmc/fsl_esdhc.c:716:2: error: unknown field 'send_cmd' specified
>> in initializer
>> .send_cmd = esdhc_send_cmd,
>> ^
>> drivers/mmc/fsl_esdhc.c:716:14: warning: excess elements in struct
>> initializer
>> .send_cmd = esdhc_send_cmd,
>> ^
>> drivers/mmc/fsl_esdhc.c:716:14: note: (near initialization for 'esdhc_ops')
>> drivers/mmc/fsl_esdhc.c:717:2: error: unknown field 'set_ios' specified
>> in initializer
>> .set_ios = esdhc_set_ios,
>> ^
>> drivers/mmc/fsl_esdhc.c:717:13: warning: excess elements in struct
>> initializer
>> .set_ios = esdhc_set_ios,
>> ^
>> drivers/mmc/fsl_esdhc.c:717:13: note: (near initialization for 'esdhc_ops')
>> drivers/mmc/fsl_esdhc.c:718:2: error: unknown field 'init' specified in
>> initializer
>> .init = esdhc_init,
>> ^
>> drivers/mmc/fsl_esdhc.c:718:11: warning: excess elements in struct
>> initializer
>> .init = esdhc_init,
>> ^
>> drivers/mmc/fsl_esdhc.c:718:11: note: (near initialization for 'esdhc_ops')
>> drivers/mmc/fsl_esdhc.c:719:2: error: unknown field 'getcd' specified in
>> initializer
>> .getcd = esdhc_getcd,
>> ^
>> drivers/mmc/fsl_esdhc.c:719:12: warning: excess elements in struct
>> initializer
>> .getcd = esdhc_getcd,
>> ^
>> drivers/mmc/fsl_esdhc.c:719:12: note: (near initialization for 'esdhc_ops')
>>
>> Can you check it ?
>
> Did you take the v7 patches? I re-based on top of u-boot-imx/master
> and it's compiled for me.
I take the v7:
http://patchwork.ozlabs.org/bundle/sbabic/jagan/
Applied on top of u-boot-imx master, I get the error. There are just a
few of new patches on the tree, I doubt that are guilty for it.
> Please see this branch [1]
>
> [1] https://mail.google.com/mail/u/1/#label/u-boot%2Fdenx/157a44636e8dc15f
>
This linkj does not work - anyway, I should pick up just patches that
are in patchwork.
Regards,
Stefano
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================
More information about the U-Boot
mailing list