[U-Boot] [PATCH v7 00/21] imx6: Add Engicam i.CoreM6 QDL support

[Jagan Teki]

Hi Stefano,

On Mon, Oct 24, 2016 at 5:05 PM, Stefano Babic <sbabic at denx.de> wrote:
> Hi Jagan,
>
> On 24/10/2016 13:03, Jagan Teki wrote:
>> Hi Stefano,
>>
>> On Mon, Oct 24, 2016 at 4:18 PM, Jagan Teki <jagan at openedev.com> wrote:
>>> On Mon, Oct 24, 2016 at 3:53 PM, Jagan Teki <jagan at openedev.com> wrote:
>>>> + Peng
>>>>
>>>> On Mon, Oct 24, 2016 at 3:46 PM, Stefano Babic <sbabic at denx.de> wrote:
>>>>> Hi Jagan, Peng,
>>>>>
>>>>> On 24/10/2016 11:05, Stefano Babic wrote:
>>>>>
>>>>>>> Did you take the v7 patches? I re-based on top of u-boot-imx/master
>>>>>>> and it's compiled for me.
>>>>>>
>>>>>> I take the v7:
>>>>>>
>>>>>> http://patchwork.ozlabs.org/bundle/sbabic/jagan/
>>>>>>
>>>>>> Applied on top of u-boot-imx master, I get the error. There are just a
>>>>>> few of new patches on the tree, I doubt that are guilty for it.
>>>>>>
>>>>>
>>>>> I got the same issue for mx6ull_14x14_evk_plugin after applying Peng's
>>>>> patches for plugins. Issue is raised in fsl_esdhc.c driver, that should
>>>>> be not yet prepared for DM_MMC_OPS.
>>>>>
>>>>> Is there a missing patch ? Could you take a look ?
>>>
>>> Got the issue, we need to update 2 recent changes from Simon
>>> patches[1][2] I will fix and update.
>>>
>>> [1] http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=896a74f615d6ffcbbcbec1505b19ed3280fe7873
>>> [2] http://git.denx.de/?p=u-boot/u-boot-imx.git;a=commitdiff;h=252788b4eda852e0195e1903e55480b4bf4fea9d
>>
>> Please try this patches, I've updated the above changes.
>>
>> [1] http://git.denx.de/?p=u-boot-spi.git;a=shortlog;h=refs/heads/engicam-working
>>
>
> No, this is not the correct way to do. We should stick with the patches
> sent to ML and included in patchworks. They are documented and I cannot
> (that means, all custodians are not allowed) to simply pick up patches
> from somewhere else.

True, but I am not saying you to just apply the branch. My intention
was to check the new changes from your side so-that will send the
series to ML again.

>
> It is enough that we agree about issue and solution. I had already
> tested with the following patch:
>
> diff --git a/configs/imx6qdl_icore_mmc_defconfig
> b/configs/imx6qdl_icore_mmc_defconfig
> index 221ea7e..c947e10 100644
> --- a/configs/imx6qdl_icore_mmc_defconfig
> +++ b/configs/imx6qdl_icore_mmc_defconfig
> @@ -6,6 +6,8 @@ CONFIG_DEFAULT_FDT_FILE="imx6dl-icore.dtb"
>  CONFIG_DEFAULT_DEVICE_TREE="imx6dl-icore"
>  CONFIG_SYS_PROMPT="icorem6qdl> "
>  CONFIG_SPL=y
> +# CONFIG_BLK is not set
> +# CONFIG_DM_MMC_OPS is not set
>  CONFIG_BOOTDELAY=3
>  CONFIG_BOARD_EARLY_INIT_F=y
>  CONFIG_DISPLAY_CPUINFO=y
> diff --git a/configs/imx6qdl_icore_nand_defconfig

nand_defconfig doesn't require this change.

> b/configs/imx6qdl_icore_nand_defconfig
> index 8ac3099..55650bb 100644
> --- a/configs/imx6qdl_icore_nand_defconfig
> +++ b/configs/imx6qdl_icore_nand_defconfig
> @@ -6,6 +6,8 @@ CONFIG_DEFAULT_FDT_FILE="imx6dl-icore.dtb"
>  CONFIG_DEFAULT_DEVICE_TREE="imx6dl-icore"
>  CONFIG_SYS_PROMPT="icorem6qdl> "
>  CONFIG_SPL=y
> +# CONFIG_BLK is not set
> +# CONFIG_DM_MMC_OPS is not set
>  CONFIG_BOOTDELAY=3
>  CONFIG_BOARD_EARLY_INIT_F=y
>  CONFIG_DISPLAY_CPUINFO=y

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.