[U-Boot] [PATCH] dm: mmc: socfpga: fix MMC_OPS support

Simon Glass sjg at chromium.org
Mon Oct 24 23:13:00 CEST 2016


On 24 October 2016 at 10:24, Sylvain Lesne <lesne at alse-fr.com> wrote:
>
> Now that CONFIG_BLK and CONFIG_MMC_OPS are enabled by default with
> CONFIG_DM_MMC, the DWMMC driver on the socfpga platform fails at
> runtime.
>
> This adds the missing fields in the driver declaration.
>
> Signed-off-by: Sylvain Lesne <lesne at alse-fr.com>
> ---
>
> Hi,
>
> I might be missing something, but with the latest master, on a
> socfpga board, I get the following failure:
>
> U-Boot SPL 2016.11-rc2-00072-g869588d-dirty (Oct 24 2016 - 17:18:22)
> drivers/ddr/altera/sequencer.c: Preparing to start memory calibration
> drivers/ddr/altera/sequencer.c: CALIBRATION PASSED
> drivers/ddr/altera/sequencer.c: Calibration complete
> Trying to boot from MMC1
> spl: partition error
> MMC: block number 0xx exceeds max(0xx)
> mmc_load_image_raw_sector: mmc block read error
> SPL: failed to boot from all boot devices
> ### ERROR ### Please RESET the board ###
>
> After some digging, it seems that the socfpga_dw_mmc driver slipped
> through the cracks during some steps of the DM conversion, so I
> added the missing fields of the driver declaration, mimicking what's
> done in the other dw_mmc_* drivers, and it works on my board.
>
> (Also, this is kind of unrelated, but it looks like the error
> message 'MMC: block number 0xx exceeds max(0xx)' has a formatting
> issue!)
>
> ---
>  drivers/mmc/socfpga_dw_mmc.c | 2 ++
>  1 file changed, 2 insertions(+)


Reviewed-by: Simon Glass <sjg at chromium.org>

The formatting issue may be due to tiny-printf.

- Simon


More information about the U-Boot mailing list