[U-Boot] [PATCH] cmd/tpm_test: Fix misleading code indentation

Simon Glass sjg at chromium.org
Tue Oct 25 20:39:53 CEST 2016


On 17 October 2016 at 16:17, Simon Glass <sjg at chromium.org> wrote:
> On 16 October 2016 at 09:13, Stefan Brüns <stefan.bruens at rwth-aachen.de> wrote:
>> GCC 6.2 reasonably complains about the current code:
>>
>> ../cmd/tpm_test.c: In function ‘do_tpmtest’:
>> ../cmd/tpm_test.c:540:3: warning: this ‘for’ clause does not guard... [-Wmisleading-indentation]
>>    for (i = 0; i < argc; i++)
>>    ^~~
>> ../cmd/tpm_test.c:542:4: note: ...this statement, but the latter is misleadingly indented as if it is guarded by the ‘for’
>>     printf("\n------\n");
>>     ^~~~~~
>>
>> Signed-off-by: Stefan Brüns <stefan.bruens at rwth-aachen.de>
>> ---
>>  cmd/tpm_test.c | 11 +++++------
>>  1 file changed, 5 insertions(+), 6 deletions(-)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Updated to drop the C99 variable decl.

Applied to u-boot-dm/next, thanks!


More information about the U-Boot mailing list