[U-Boot] [PATCH] drivers/pci/Kconfig: Add PCI

[Simon Glass]

Hi Tom,

On 24 October 2016 at 13:13, Tom Rini <trini at konsulko.com> wrote:
> Add 'PCI' as a menu option and migrate all existing users.
>
> Signed-off-by: Tom Rini <trini at konsulko.com>
> ---
> Tegra is in a funny spot here.  TEGRA_COMMON will select DM_PCI and
> DM_PCICOMPAT.  But adding PCI to the list here results in the following:
>    aarch64: (for 61/61 boards) all +217.7 data +24.8 rodata +47.9 text +145.0
>             p2571          : all +4426 data +504 rodata +974 text +2948
>             e2220-1170     : all +4426 data +504 rodata +974 text +2948
>             p2371-0000     : all +4426 data +504 rodata +974 text +2948
>        arm: (for 557/557 boards) all +96.9 bss +0.1 data +7.2 rodata +23.7 spl/u-boot-spl:all +0.1 spl/u-boot-spl:rodata +0.1 spl/u-boot-spl:text +0.0 text +65.9
>             whistler       : all +3914 bss +28 data +288 rodata +934 spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2664
>             paz00          : all +3908 bss +16 data +280 rodata +952 text +2660
>             colibri_t30    : all +3898 bss +12 data +280 rodata +934 spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2672
>             venice2        : all +3862 bss +28 data +288 rodata +934 spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
>             plutux         : all +3850 bss +32 data +280 rodata +934 spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2604
>             nyan-big       : all +3852 bss -4 data +296 rodata +952 text +2608
>             dalmore        : all +3846 bss +12 data +288 rodata +934 spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
>             seaboard       : all +3848 bss +8 data +288 rodata +952 text +2600
>             medcom-wide    : all +3848 bss +16 data +280 rodata +952 text +2600
>             harmony        : all +3848 bss +8 data +288 rodata +952 text +2600
>             tec-ng         : all +3842 bss +8 data +288 rodata +934 spl/u-boot-spl:all +4 spl/u-boot-spl:text +4 text +2612
>             ventana        : all +3844 bss -48 data +280 rodata +952 text +2660
>             colibri_t20    : all +3836 bss -4 data +288 rodata +952 text +2600
>             tec            : all +3784 bss -48 data +280 rodata +952 text +2600
>
> Because prior to this patch they did not set PCI and thus what code was
> build here was largely discarded at link time.  One or two of the above
> look to fall in to the case where PCI_TEGRA should be off, but not all.
> What should we do about this?

I don't think this matters. The maintainer could always adjust the
options after this patch is applied, if needed.

Reviewed-by: Simon Glass <sjg at chromium.org>

Regards,
Simon