[U-Boot] [PATCH] arm: dts: Pine64: add Ethernet alias

[Jagan Teki]

On Sun, Oct 30, 2016 at 3:16 PM, André Przywara <andre.przywara at arm.com> wrote:
> On 30/10/16 08:48, Jagan Teki wrote:
>> On Fri, Oct 28, 2016 at 11:21 PM, Jagan Teki <jagan at openedev.com> wrote:
>>> On Thu, Oct 27, 2016 at 2:20 AM, André Przywara <andre.przywara at arm.com> wrote:
>>>> On 26/10/16 19:51, Jagan Teki wrote:
>>>> Hi,
>>>>
>>>>> On Fri, Oct 21, 2016 at 5:41 AM, Andre Przywara <andre.przywara at arm.com> wrote:
>>>>>> The sun8i-emac driver works fine with the A64 Ethernet IP, but we are
>>>>>> missing an alias entry to trigger the driver instantiation by U-Boot.
>>>>>> Add the line to point U-Boot to the Ethernet DT node.
>>>>>> This enables TFTP boot on the Pine64.
>>>>>>
>>>>>> Signed-off-by: Andre Przywara <andre.przywara at arm.com>
>>>>>> ---
>>>>>>  arch/arm/dts/sun50i-a64-pine64-common.dtsi | 1 +
>>>>>>  1 file changed, 1 insertion(+)
>>>>>>
>>>>>> diff --git a/arch/arm/dts/sun50i-a64-pine64-common.dtsi b/arch/arm/dts/sun50i-a64-pine64-common.dtsi
>>>>>> index d5a7249..c0fde44 100644
>>>>>> --- a/arch/arm/dts/sun50i-a64-pine64-common.dtsi
>>>>>> +++ b/arch/arm/dts/sun50i-a64-pine64-common.dtsi
>>>>>> @@ -46,6 +46,7 @@
>>>>>>
>>>>>>         aliases {
>>>>>>                 serial0 = &uart0;
>>>>>> +               ethernet0 = &emac;
>>>>>
>>>>> Better to have this alias on sun50i-a64.dtsi since the node is defined there?
>>>>
>>>> Mmh, I find examples for both ways (.dtsi vs. .dts) in the kernel. I
>>>> need to learn what's the best practice here.
>>>>
>>>> But the U-Boot DTs need to get replaced anyway soon-ish, since the Linux
>>>> DTs (which are WIP) have already diverged.
>>>> So what about we keep this alias here next to the existing one for the
>>>> 2016.11 release and possibly fix this later once we replace the DTs
>>>> anyway with what gets merged into the kernel eventually?
>>>
>>> OK, but please stick with the current discussion and still I see a
>>> good point to see alias on dtsi because the dts files which are using
>>> this dtsi shouldn't separately define the alias.
>>>
>>> And also status on dtsi is showing "disabled" are you enabled it some
>>> other patches? or missed?
>
> We have the status = "okay" in sun50i-a64-pine64-plus.dts, which is the
> only dts that is used these days.
> The non-plus board version has a different PHY (100 MBit only) and a
> quick test a while ago showed that this didn't work out of the box, so
> we just don't enable it there. It seems like that not many people have
> this version of the board and they would need to hack U-Boot to use it
> anyway (because defconfig select -plus.dts).
> This will be revisited when the SPL FIT support introduces board
> detection and we actually choose the proper DT for each board.

OK.

Reviewed-by: Jagan Teki <jagan at openedev.com>

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.