[U-Boot] [PATCH v5 01/21] sf: Adopt flash table INFO macro from Linux

[Jagan Teki]

On Mon, Oct 31, 2016 at 3:13 PM, Vignesh R <vigneshr at ti.com> wrote:
>
>
> On Monday 31 October 2016 03:05 PM, Jagan Teki wrote:
>> On Mon, Oct 31, 2016 at 3:02 PM, Vignesh R <vigneshr at ti.com> wrote:
>>>
>>>
>>> On Monday 31 October 2016 02:50 PM, Jagan Teki wrote:
>>>> On Mon, Oct 31, 2016 at 2:24 PM, Jagan Teki <jagan at openedev.com> wrote:
>>>>> On Mon, Oct 31, 2016 at 8:48 AM, Vignesh R <vigneshr at ti.com> wrote:
>>>>>>
>>>>>>
>>>>>> On Sunday 30 October 2016 11:16 PM, Jagan Teki wrote:
>>>>>> [...]
>>>>>>> +     {"S25FL128P_64K",  INFO(0x012018, 0x0301,  64 * 1024,   256, RD_FULL | WR_QPP) },
>>>>>>> +     {"S25FL032P",      INFO(0x010215, 0x4d00,  64 * 1024,    64, RD_FULL | WR_QPP) },
>>>>>>> +     {"S25FL064P",      INFO(0x010216, 0x4d00,  64 * 1024,   128, RD_FULL | WR_QPP) },
>>>>>>> +     {"S25FL128S_256K", INFO(0x012018, 0x4d00, 256 * 1024,    64, RD_FULL | WR_QPP) },
>>>>>>> +     {"S25FL128S_64K",  INFO(0x012018, 0x4d01,  64 * 1024,   256, RD_FULL | WR_QPP) },
>>>>>>> +     {"S25FL256S_256K", INFO(0x010219, 0x4d00, 256 * 1024,   128, RD_FULL | WR_QPP) },
>>>>>>> +     {"S25FL256S_64K",  INFO(0x010219, 0x4d01,  64 * 1024,   512, RD_FULL | WR_QPP) },
>>>>>>> +     {"S25FS512S",      INFO(0x010220, 0x4D00, 128 * 1024,   512, RD_FULL | WR_QPP) },
>>>>>>> +     {"S25FL512S_256K", INFO(0x010220, 0x4d00, 256 * 1024,   256, RD_FULL | WR_QPP) },
>>>>>>
>>>>>> Could you change above S25FS512S and S25FL512S_256K to use INFO6 macro?
>>>>>> Right now, S25FL512S_256K gets detected as S25FS512S and sf update fails
>>>>>> due as erasesizes are different.
>>>>>
>>>>> I think this seems to be an existing issue, even before these changes.
>>>>> after this [1] I will prepare a patch to use INFO6 for S25FS512S.
>>>>>
>>>>> [1] http://git.denx.de/?p=u-boot-spi.git;a=commitdiff;h=13c17cad45ad9040fd0f6ebadf76554eb6353381
>>>>
>>>> Try u-boot-spi/next?
>>>>
>>>
>>> Yes, that works. sf probe correctly detects S25FL512S_256K. Thanks!
>>
>> Now it's s25fl512s_256k changed to lower-case hope you detect the same?
>>
>
> Yes here is the log :
>
> U-Boot 2016.11-rc2-00220-g53b750eed351 (Oct 31 2016 - 14:57:11 +0530)
>
> CPU: 66AK2Gx SR1.0
> Model: Texas Instruments Keystone 2 Galileo EVM
> I2C:   ready
> DRAM:
> Clear entire DDR3 memory to enable ECC
> 2 GiB
> MMC:   OMAP SD/MMC: 0, OMAP SD/MMC: 1
> reading uboot.env
>
> ** Unable to read "uboot.env" from mmc0:1 **
> Using default environment
>
> Net:
> Warning: netcp at 4000000 using MAC address from ROM
> eth0: netcp at 4000000
> Hit any key to stop autoboot:  0
> => sf probe 4:0
> SF: Detected s25fl512s_256k with page size 512 Bytes, erase size 256
> KiB, total 64 MiB
> =>

Perfect, thanks!

-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.