[U-Boot] [PATCH v3 1/2] ARM: at91: gpio: fix at91_set_gpio_value() define

Simon Glass sjg at chromium.org
Sat Apr 1 04:21:32 UTC 2017


On 22 March 2017 at 22:55, Wenyou Yang <wenyou.yang at atmel.com> wrote:
> When the CONFIG_ATMEL_LEGACY is undefined, according to the following
> defines, at91_set_gpio_value() references to at91_set_pio_value(x, y)
> with two parameters.
>  #define at91_set_gpio_value(x, y)      at91_set_pio_value(x, y)
>  #define at91_get_gpio_value(x)         at91_get_pio_value(x)
>
> But there isn't the implementation of at91_set_pio_value(x, y) with
> two parameters in U-Boot. This is an error.
>
> Same as at91_get_gpio_value(x) define.
>
> Signed-off-by: Wenyou Yang <wenyou.yang at atmel.com>
> ---
>
> Changes in v3: None
> Changes in v2:
>  - Improve the commit log.
>
>  arch/arm/mach-at91/include/mach/gpio.h | 12 +++++-------
>  1 file changed, 5 insertions(+), 7 deletions(-)

Reviewed-by: Simon Glass <sjg at chromium.org>


More information about the U-Boot mailing list