[U-Boot] regression: setting the rpi mac address stopped working

[Simon Glass]

Hi,

On 27 March 2017 at 02:24, Gerd Hoffmann <kraxel at redhat.com> wrote:
>   Hi,
>
> u-boot 2016.11 & newer doesn't set the mac address on my raspberry pi
> any more, so the linux kernel picks a random mac address.  Bisected to
> this commit:
>
> commit b91c6a1209e7da1a7f989d9ac35d0d8be0b7b710
> Author: Simon Glass <sjg at chromium.org>
> Date:   Wed Oct 5 20:42:11 2016 -0600
>
>     Fix return value in trailing_strtoln()
>
>     This function should return -1 if there is no trailing integer
>     in the string. Instead it returns 0. Fix it by checking for this
>     condition at the start.
>
>     Signed-off-by: Simon Glass <sjg at chromium.org>
>     Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
>
> Appearently this change broke fdt_fixup_ethernet().

I'm sorry to hear that. Any change you have a patch? It looks like the
latter code was relying on the bad behaviour?

Regards,
Simon