[U-Boot] [PATCH] Remove extra fdt_fixup_ethernet() call

Simon Glass sjg at chromium.org
Sat Apr 1 04:21:56 UTC 2017


Hi Joakim,

On 23 March 2017 at 11:02, Joakim Tjernlund
<joakim.tjernlund at infinera.com> wrote:
> ft_cpu_setup() already calls fdt_fixup_ethernet(), calling it
> in image_setup_libfdt() is both redundant and breaks any modifications
> done by ft_board_setup(). Restore the old behavior by removing
> the call in image_setup_libfdt()

Which old behaviour? Can you please add a Fixes: tag with the details?

Also, which ft_cpu_setup()?

>
> Signed-off-by: Joakim Tjernlund <joakim.tjernlund at infinera.com>
> ---
>  common/image-fdt.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/common/image-fdt.c b/common/image-fdt.c
> index 80e3e63..b8f5654 100644
> --- a/common/image-fdt.c
> +++ b/common/image-fdt.c
> @@ -498,7 +498,6 @@ int image_setup_libfdt(bootm_headers_t *images, void *blob,
>                         goto err;
>                 }
>         }
> -       fdt_fixup_ethernet(blob);
>
>         /* Delete the old LMB reservation */
>         lmb_free(lmb, (phys_addr_t)(u32)(uintptr_t)blob,
> --
> 2.10.2
>

Regards,
Simon


More information about the U-Boot mailing list