[U-Boot] unused-const-variable warnings in FSL DDR driver

Tom Rini trini at konsulko.com
Tue Apr 4 14:52:24 UTC 2017


On Mon, Mar 27, 2017 at 09:32:26AM +0000, Thomas Schaefer wrote:

> > From: york sun [mailto:york.sun at nxp.com] 
> > Sent: Samstag, 25. März 2017 16:35
> > To: Thomas Schaefer; Tom Rini
> > Cc: u-boot at lists.denx.de
> > Re: Re: AW: [U-Boot] unused-const-variable warnings in FSL DDR driver
> >
> > Thomas,
> >
> > Can you put your patch together with proper commit message and signature? I prefer your solution than this one http://patchwork.ozlabs.org/patch/726353/
> >
> > York
> >
> 
> Hi York,
> 
> please find the patch in the attachment.
> 
> Best regards,
> Thomas
> 
> 
> commit 66dcf316bf2649e576f1b79aad3a5bb950d178d6
> Author: Thomas Schaefer <thomas.schaefer at kontron.com>
> Date:   Mon Mar 27 10:17:09 2017 +0200
> 
>     drivers: ddr: fix unused-const-variable warnings
> 
>     Depending on DDR configuration, gcc-6.x will show up unused-const-
>     variable messages. Use __maybe_unused specifier for all dynamic_odt
>     variable definitions to remove these warnings.
> 
>     Memory footprint will not increase as gcc will optimize out unused
>     constants.
> 
>     Signed-off-by: Thomas Schaefer <thomas.schaefer at kontron.com>
> 
> diff --git a/drivers/ddr/fsl/options.c b/drivers/ddr/fsl/options.c
> index d6a8fcb216..64aaa77047 100644

Reviewed-by: Tom Rini <trini at konsulko.com>



-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170404/7dededa6/attachment.sig>


More information about the U-Boot mailing list