[U-Boot] [PATCH] common, kconfig: Fix defaut value of BOOTSTAGE_STASH_SIZE

Tom Rini trini at konsulko.com
Wed Apr 5 13:42:59 UTC 2017


On Sun, Apr 02, 2017 at 11:22:42AM +0200, Wolfgang Denk wrote:
> Dear Nobuhiro,
> 
> In message <20170401224812.11646-1-iwamatsu at nigauri.org> you wrote:
> > The default value of BOOTSTAGE_STASH_SIZE should be set to hexadecimal,
> > but an integer value is set. This fixes the BOOTSTAGE_STASH_SIZE number
> > from hexadecimal to integer.
> ...
> > -	default 4096
> > +	default 0x1000
> >  	help
> >  	  This should be large enough to hold the bootstage stash. A value of
> >  	  4096 (4KiB) is normally plenty.
> 
> Would it make sense to also fix the help message, and maybe even to
> add a note to the help message that this should be a hex number?

Yes, perhaps s/4096/0x1000/ in the help message will be clear enough
since Kconfig tooling will take care of saying "THIS IS HEX!" somwwhere
relevant.  Thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170405/f30d03e3/attachment.sig>


More information about the U-Boot mailing list