[U-Boot] [PATCH v3 2/2] x86: Introduce minimal PMU driver for Intel MID platforms

[Simon Glass]

Hi Andy,

On 1 April 2017 at 07:21, Andy Shevchenko
<andriy.shevchenko at linux.intel.com> wrote:
> This simple PMU driver allows to tyrn power on and off for selected
> devices. In particularly Intel Tangier needs to power on SDHCI
> controllers in order to access to them during board initialization.
>
> In the future it might be expanded to cover other Intel MID platforms,
> that's why it's located under arch/x86/lib and called pmu.c.
>
> Signed-off-by: Felipe Balbi <felipe.balbi at linux.intel.com>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko at linux.intel.com>
> ---
>  arch/x86/include/asm/cpu.h |   1 +
>  arch/x86/include/asm/pmu.h |  11 +++++
>  arch/x86/lib/Makefile      |   1 +
>  arch/x86/lib/pmu.c         | 117 +++++++++++++++++++++++++++++++++++++++++++++
>  4 files changed, 130 insertions(+)
>  create mode 100644 arch/x86/include/asm/pmu.h
>  create mode 100644 arch/x86/lib/pmu.c

Reviewed-by: Simon Glass <sjg at chromium.org>

Have you considered making this a PMIC driver? Then you could avoid
exporting the function. Also I see that we need to do that sometimes
with Intel platforms.