[U-Boot] [PATCH 7/7] crash when scroll screen

[Simon Glass]

Hi Eric,

On 1 April 2017 at 08:42,  <eric.gao at rock-chips.com> wrote:
> From: "eric.gao" <eric.gao at rock-chips.com>
>
> After enable log printing to lcd,when the screen start scroll,the
> system crash.And the log is shown as bellow.
>
> "Synchronous Abort" handler, esr 0x96000045
> "Synchronous Abort" handler, esr 0x96000045
>
> Checking the source code, we found that the variate "pixels"
> get a wrong value.
>
> int pixels = VIDEO_FONT_HEIGHT * vid_priv->line_length;
>
> "pixels" here means the value of pixels for a character,rather than
> the byte for a character. so the variate "pixels" is 4 times bigger
> than it's exact value. which will cause the memory overflow when the
> cpu run the following code.
>
> for (i = 0; i < pixels; i++)
>     *dst++ = clr; <<----
>
> Signed-off-by: eric.gao <eric.gao at rock-chips.com>
> ---
>
>  drivers/video/console_normal.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Can you compare with this patch?

Reviewed-by: Simon Glass <sjg at chromium.org>

I did not apply it as it was part of a larger series, sorry.

Regards,
Simon