[U-Boot] [U-Boot, 2/2] common/xyzModem.c: Do not use hard-coded address for debug buffer

Tom Rini trini at konsulko.com
Sun Apr 9 01:15:43 UTC 2017


On Tue, Apr 04, 2017 at 10:42:31AM -0700, Alexandru Gagniuc wrote:

> Under the plethora of #ifdefs, the xyzModem code hid this pearl:
> static char *zm_out = (char *) 0x00380000;
> This was only enabled when DEBUG is defined, so it's probably why it
> went unnoticed for so long. No idea what platform had memory at that
> exact location, but the this approach is extremely hacky.
> Use a static buffer instead.
> 
> Signed-off-by: Alexandru Gagniuc <alex.g at adaptrum.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170408/3b2b5fc2/attachment.sig>


More information about the U-Boot mailing list