[U-Boot] [PATCH 2/3] fsl-ppa: Kconfig: Support to load PPA hdr from eMMC/SD and NAND Flash

[Sumit Garg]

> -----Original Message-----
> From: York Sun [mailto:york.sun at nxp.com]
> Sent: Friday, April 07, 2017 9:41 PM
> To: Sumit Garg <sumit.garg at nxp.com>; u-boot at lists.denx.de
> Cc: Ruchika Gupta <ruchika.gupta at nxp.com>; Prabhakar Kushwaha
> <prabhakar.kushwaha at nxp.com>; Vini Pillai <vinitha.pillai at nxp.com>; Udit
> Agarwal <udit.agarwal at nxp.com>
> Subject: Re: [PATCH 2/3] fsl-ppa: Kconfig: Support to load PPA hdr from
> eMMC/SD and NAND Flash
> 
> On 04/07/2017 04:42 AM, Sumit Garg wrote:
> > Add support to load PPA hdr from eMMC/SD and NAND Flash in Kconfig
> >
> > Signed-off-by: Sumit Garg <sumit.garg at nxp.com>
> > Signed-off-by: Udit Agarwal <udit.agarwal at nxp.com>
> > Tested-by: Vinitha Pillai <vinitha.pillai at nxp.com>
> > ---
> >  arch/arm/cpu/armv8/fsl-layerscape/Kconfig | 10 ++++++++++
> >  1 file changed, 10 insertions(+)
> >
> > diff --git a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
> > b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
> > index 9fb76f0..4c9b6ce 100644
> > --- a/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
> > +++ b/arch/arm/cpu/armv8/fsl-layerscape/Kconfig
> > @@ -179,12 +179,22 @@ config SYS_LS_PPA_ESBC_ADDR
> >  	default 0x40740000 if SYS_LS_PPA_FW_IN_XIP && ARCH_LS1046A
> >  	default 0x40480000 if SYS_LS_PPA_FW_IN_XIP && ARCH_LS1012A
> >  	default 0x580c40000 if SYS_LS_PPA_FW_IN_XIP && FSL_LSCH3
> > +	default 0x700000 if SYS_LS_PPA_FW_IN_MMC
> > +	default 0x700000 if SYS_LS_PPA_FW_IN_NAND
> >  	help
> >  	  If the PPA header firmware locate at XIP flash, such as NOR or
> >  	  QSPI flash, this address is a directly memory-mapped.
> >  	  If it is in a serial accessed flash, such as NAND and SD
> >  	  card, it is a byte offset.
> >
> > +config LS_PPA_ESBC_HDR_SIZE
> > +	hex "Length of PPA ESBC header"
> > +	depends on FSL_LS_PPA && CHAIN_OF_TRUST &&
> !SYS_LS_PPA_FW_IN_XIP
> > +	default 0x2000
> > +	help
> > +	  Length (in bytes) of PPA ESBC header to be copied from MMC/SD or
> > +	  NAND to memory to validate PPA image.
> > +
> >  endmenu
> >
> 
> The order of patches seems wrong. You add two Kconfig options here but you
> use them in your patch #1.
> 
> York

I will correct the order in next version. Please let me know if you have any further comments.

Sumit