[U-Boot] [PATCHv2] net: zynq_gem: Do not return -ENOSYS on success

Joe Hershberger joe.hershberger at gmail.com
Mon Apr 10 22:17:44 UTC 2017


Hi Michal,

On Wed, Apr 5, 2017 at 4:17 AM, Michal Simek <michal.simek at xilinx.com> wrote:
> On 4.4.2017 19:53, Joe Hershberger wrote:
>> On Mon, Apr 3, 2017 at 9:18 AM, Olliver Schinagl <oliver at schinagl.nl> wrote:
>>>
>>> The .read_rom_hwaddr net_ops hook does not check the return value, which
>>> is why it was never caught that we are currently returning 0 if the
>>> read_rom_hwaddr function return -ENOSYS and -ENOSYS otherwise.
>>>
>>> In this case we can simplify this by just returning the result of the
>>> function.
>>>
>>> Signed-off-by: Olliver Schinagl <oliver at schinagl.nl>
>>
>> Acked-by: Joe Hershberger <joe.hershberger at ni.com>
>>
>
> Acked-by: Michal Simek <michal.simek at xilinx.com>
>
> Joe: Can you please take this via your tree?

Will do.

-Joe


More information about the U-Boot mailing list