[U-Boot] [PATCH] rockchip: rk3399: defconfig: add CONFIG_OF_EMBED support

[Kever Yang]

Hi Simon,


On 04/11/2017 09:55 PM, Simon Glass wrote:
> Hi Kever,
>
> On 9 April 2017 at 20:36, Kever Yang <kever.yang at rock-chips.com> wrote:
>> Hi Simon,
>>
>>
>> On 04/10/2017 03:28 AM, Simon Glass wrote:
>>> Hi Kever,
>>>
>>> On 7 April 2017 at 04:35, Kever Yang <kever.yang at rock-chips.com> wrote:
>>>> Need to enablt CONFIG_OF_EMBED if we use separate uboot and dtb
>>>> in FIT image for SPL loading.
>>>>
>>> Can you please explain that a bit more? We shouldn't OF_EMBED in
>>> production code, only for debug/test.
>>
>> When I test with latest code for SPL loading FIT which u-boot and dtb
>> are separate, the U-Boot code can not find its dtb file.
>> This issue is not happen when I test with code older than v2017.03,
>> and with CONFIG_OF_EMBED, U-Boot can find dtb with latest code.
>>
>> Maybe I need to do some debugging for root cause, please ignore this
>> patch if this is not correct.
> Yes this needs to be figured out. If you have the debug UART enabled
> you should be able to add debugging to fdtdec_setup() to see what is
> happening. Perhaps the DT is not word-aligned?

I find the root cause.
I try to truncate the input image like uboot-no-dtb.bin and u-boot.dtb to
block size 512, so the SPL get the image size is 512 aligned,
but the fdtdec_setup() using the end of image address &_end which is not
512 aligned, and can not find available dtb.

I want to make the mkimage output header and input image aligned to
512 to reduce no necessary copy.

Thanks,
- Kever
>
> Regards,
> Simon
>
>> Thanks,
>> - Kever
>>
>>>> Run make savedefconfig to make the options order correct.
>>>>
>>>> Signed-off-by: Kever Yang <kever.yang at rock-chips.com>
>>>> ---
>>>>
>>>>    configs/evb-rk3399_defconfig | 43
>>>> ++++++++++++++++++++-----------------------
>>>>    1 file changed, 20 insertions(+), 23 deletions(-)
>>> Regards,
>>> Simon
>>>
>>