[U-Boot] [PATCH 1/1] odroid-c2: enable MMC as boot target

[Andreas Färber]

Am 14.04.2017 um 15:50 schrieb Heinrich Schuchardt:
> On 04/14/2017 03:42 PM, Andreas Färber wrote:
>> Am 14.04.2017 um 13:46 schrieb Heinrich Schuchardt:
>>> To enable booting from MMC the MMC devices 0 and 1 are added to the
>>
>> from eMMC

Sorry, was getting confused with the multiple submissions here.

SD and eMMC, or just MMC as you had it.

And "automatic booting" would be more accurate, as one could manually boot.

>>
>>> BOOT_TARGET_DEVICES.
>>>
>>> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
>>> ---
>>> This is a resubmission of
>>> https://lists.denx.de/pipermail/u-boot/2017-April/287315.html
>>> where this patch was part of patch series which was no longer applicable.
>>> ---
>>>  include/configs/meson-gxbb-common.h | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git a/include/configs/meson-gxbb-common.h b/include/configs/meson-gxbb-common.h
>>> index cc2b5b6..388f239 100644
>>> --- a/include/configs/meson-gxbb-common.h
>>> +++ b/include/configs/meson-gxbb-common.h
>>> @@ -39,6 +39,8 @@
>>>  #include <config_distro_defaults.h>
>>>  
>>>  #define BOOT_TARGET_DEVICES(func) \
>>> +	func(MMC, mmc, 0) \
>>> +	func(MMC, mmc, 1) \
>>
>> What if booting on SD fails and eMMC is absent? Will that still iterate
>> on to DHCP?
> 
> Yes, the targets are tried in sequence.
> So if neither SD nor eMMC are available DHCP is tried.
> You will find the same for a lot of other boards (e.g. wandboard.h).
> 
> For details refer to chapter "Boot Target Configuration" in
> doc/README.distro.

I am familiar with other boards, but in my previous testing of older
patches it hang when accessing an absent MMC device. So the question is
about whether the S905 driver handles it okay.

BTW had the commit message indicated it I wouldn't ask. :)

Regards,
Andreas

-- 
SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)