[U-Boot] [PATCH] drivers/usb/ehci: Use platform-specific accessors

Tom Rini trini at konsulko.com
Mon Apr 17 16:31:36 UTC 2017


On Mon, Apr 17, 2017 at 04:19:17PM +0000, Alexey Brodkin wrote:
> Hi Tom, Marek,
> 
> On Fri, 2017-04-14 at 16:06 -0400, Tom Rini wrote:
> > On Fri, Apr 14, 2017 at 05:16:11PM +0000, Alexey Brodkin wrote:
> > > 
> > > Hi Marek,
> > > 
> > > On Fri, 2017-04-14 at 16:44 +0200, Marek Vasut wrote:
> > > > 
> > > > On 03/24/2017 01:56 PM, Marek Vasut wrote:
> > > > > 
> > > > >  
> > > > Even better, this patch breaks powerpc board lwmon5, so dropped.
> > > 
> > > Are you sure the problem is in my patch?
> > 
> > Yes, it is.  Dropping this from the USB PR gets everything going again.
> 
> Ok the problem was obvious missing inclusion f "asm/io.h".
> Fix is submitted here http://patchwork.ozlabs.org/patch/751397/
> 
> Please consider for applying.

Thanks.

> > > Maybe this PPC board just needs to UNdefine
> > > CONFIG_EHCI_DESC_BIG_ENDIAN or there's a problem in its either
> > > cpu_to_XXX() or readl()/writel()?
> > > 
> > > Stefan, could you please look at what's wrong here
> > > if you have the board handy?
> > 
> > Well, since this is your set of changes, you should have some idea
> > what's right/wrong here given what things are before/after.  Also, for
> > wide changes like this, please give things a build either in travis-ci
> > (so that most of the world is built) or do most of the world locally
> > before posting, thanks!
> 
> Well I tried to run a buildman locally (thanks to machine resources I have)
> but out of 1243 boards 154 have fatal problems if I use toolchains obtained
> via buildbot. Which is barely useful for capturing issues introduced by
> incremental patches :(

Did you mean buildman?  If you look at .travis.yml that builds all of
those boards (well, with the exception of some we need gcc-6 in order to
have small enough binaries for) and that's pretty close to 1200 I think.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170417/d86c6f32/attachment.sig>


More information about the U-Boot mailing list