[U-Boot] [PATCH 02/16] x86: Display the SPL banner only once

Bin Meng bmeng.cn at gmail.com
Tue Apr 18 07:34:12 UTC 2017


On Tue, Apr 18, 2017 at 3:30 PM, Bin Meng <bmeng.cn at gmail.com> wrote:
> On Wed, Apr 12, 2017 at 11:29 AM, Simon Glass <sjg at chromium.org> wrote:
>> Hi Bin,
>>
>> On 11 April 2017 at 21:09, Bin Meng <bmeng.cn at gmail.com> wrote:
>>>
>>> Hi Simon,
>>>
>>> On Mon, Mar 20, 2017 at 2:59 AM, Simon Glass <sjg at chromium.org> wrote:
>>> > At present on a cold reboot we must reset the CPU to get it to full speed.
>>> > With 64-bit U-Boot this happens in SPL. At present we print the banner
>>> > before doing this, the end result being that we print the banner twice.
>>> > Print the banner a little later (after the CPU is ready) to avoid this.
>>> >
>>> > Signed-off-by: Simon Glass <sjg at chromium.org>
>>> > ---
>>> >
>>> >  arch/x86/lib/spl.c | 3 +--
>>> >  1 file changed, 1 insertion(+), 2 deletions(-)
>>> >
>>>
>>> Looks no difference when testing this on QEMU 64-bit. Am I missing anything?
>>
>> I suspect that QEMU doesn't have this problem, but on chromebook_link
>> we have to reset to change the CPU speed.
>>
>
> That makes sense.
>
> Reviewed-by: Bin Meng <bmeng.cn at gmail.com>
> Tested on QEMU
> Tested-by: Bin Meng <bmeng.cn at gmail.com>

applied to u-boot-x86, thanks!


More information about the U-Boot mailing list