[U-Boot] [PATCH 3/3] spl: Makefile: include /config in the (reduced) FDT used by the SPL stage

Dr. Philipp Tomsich philipp.tomsich at theobroma-systems.com
Tue Apr 18 08:30:31 UTC 2017


On 18 Apr 2017, at 06:00, Simon Glass <sjg at chromium.org> wrote:
> 
> On 17 April 2017 at 09:45, Philipp Tomsich <philipp.tomsich at theobroma-systems.com> wrote:
> > When OF control is enabled for the SPL stage, nodes are removed from
> > the DTB to reduce its size. While /chosen is kept, /config is removed.
> >
> > There's no reason why /chosen should be kept over /config (and as we
> > would like to put properties into /config that control the SPL stage),
> > we add '/config' to the list of nodes to be retained for the SPL stage.
> >
> > Signed-off-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
> > ---
> >
> > scripts/Makefile.spl | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> Acked-by: Simon Glass <sjg at chromium.org>
> 
> I hope we don't end up having to filter the properties to include!

Both the /config and /chosen nodes are passed through the CONFIG_OF_SPL_REMOVE_PROPS
filter anyway:
> quiet_cmd_fdtgrep = FDTGREP $@
>       cmd_fdtgrep = $(objtree)/tools/fdtgrep $(fdtgrep_props) -RT $< \
>                 -n /chosen -n /config -O dtb | \
>         $(objtree)/tools/fdtgrep -r -O dtb - -o $@ \
>                 $(addprefix -P ,$(subst $\",,$(CONFIG_OF_SPL_REMOVE_PROPS)))

If anybody wanted to filter these, then there’s a mechanisms in place already.


More information about the U-Boot mailing list