[U-Boot] [PATCH] spl: dfu: compilation fixes for spl-dfu

B, Ravi ravibabu at ti.com
Wed Apr 19 07:19:24 UTC 2017


Hi Lukasz

>> diff --git a/common/cli.c b/common/cli.c index a433ef2..5e0869b 100644
>> --- a/common/cli.c
>> +++ b/common/cli.c
>> @@ -28,7 +28,7 @@ DECLARE_GLOBAL_DATA_PTR;
>>   */
>>  int run_command(const char *cmd, int flag)  { -#ifndef 
>> CONFIG_HUSH_PARSER
>> +#if defined(CONFIG_SPL_DFU_SUPPORT) || !defined(CONFIG_HUSH_PARSER)

>I must admit that this seems odd to me....since we should avoided adding
> (SPL DFU) dependency to common parser code.

Yes, I agree, or use CONFIG_SPL_BUILD.

>Maybe some kconfig tweaks would help?

You Mean, unselect CONFIG_HUSH_PARSER when SPL_DFU_SUPPORT enabled?

Regards
Ravi




More information about the U-Boot mailing list