[U-Boot] [PATCH] spl: dfu: compilation fixes for spl-dfu
B, Ravi
ravibabu at ti.com
Wed Apr 19 11:00:43 UTC 2017
Hi Lukasz
>>
>> diff --git a/common/Makefile b/common/Makefile index bcd2486..dc5cb1d
>> 100644
>> --- a/common/Makefile
>> +++ b/common/Makefile
>> @@ -90,7 +90,6 @@ endif # !CONFIG_SPL_BUILD
>>
>> ifdef CONFIG_SPL_BUILD
>> obj-$(CONFIG_SPL_DFU_SUPPORT) += dfu.o
>> -obj-$(CONFIG_SPL_DFU_SUPPORT) += cli_hush.o
>> obj-$(CONFIG_SPL_HASH_SUPPORT) += hash.o
>> obj-$(CONFIG_ENV_IS_IN_FLASH) += env_flash.o
>> obj-$(CONFIG_SPL_YMODEM_SUPPORT) += xyzModem.o diff --git
>> a/common/cli.c b/common/cli.c index a433ef2..3dd4c2b 100644
>> --- a/common/cli.c
>> +++ b/common/cli.c
>> @@ -28,7 +28,7 @@ DECLARE_GLOBAL_DATA_PTR;
>> */
>> int run_command(const char *cmd, int flag) { -#ifndef
>> CONFIG_HUSH_PARSER
>> +#if defined(CONFIG_SPL_BUILD) || !defined(CONFIG_HUSH_PARSER)
>> /*
>> * cli_run_command can return 0 or 1 for success, so clean up
>> * its result.
>So for the initial support of the DFU in SPL you did not needed the HUSH parser.
>What is the motivation to enable it now? Enabling the HUSH in SPL should make the binary even bigger - hence it is counterintuitive.
The CONFIG_HUSH_PARSER is enabled in dra7xx_evm_defconfig by commit: adad96e: configs: Re-sync HUSH options
Hence CONFIG_HUSH_PARSER included for both SPL and u-boot as well.
The cli.c is common for both SPL & u-boot.
Regards
Ravi
More information about the U-Boot
mailing list