[U-Boot] [PATCH] rockchip: mkimage: remove (left-over) assignment w/o effect [coverity]

Philipp Tomsich philipp.tomsich at theobroma-systems.com
Wed Apr 19 13:09:04 UTC 2017


An assignment (of a value to itself) was left over (after removing and
addition from the line) from moving the common padding code into
rkcommon_vrec_header.

This change removes this to avoid a spurious warning in static code
analysis (i.e. Coverity).

Signed-off-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
---

 tools/rkcommon.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/rkcommon.c b/tools/rkcommon.c
index 1316b9a..f4d932b 100644
--- a/tools/rkcommon.c
+++ b/tools/rkcommon.c
@@ -376,7 +376,6 @@ int rkcommon_vrec_header(struct image_tool_params *params,
 	/* Allocate, clear and install the header */
 	tparams->hdr = malloc(tparams->header_size);
 	memset(tparams->hdr, 0, tparams->header_size);
-	tparams->header_size = tparams->header_size;
 
 	/*
 	 * If someone passed in 0 for the alignment, we'd better handle
-- 
1.9.1



More information about the U-Boot mailing list