[U-Boot] [PATCH v1 2/8] rockchip: mkimage: rewrite padding calculation for SD/MMC and SPI images

Simon Glass sjg at chromium.org
Thu Apr 20 21:06:21 UTC 2017


On 17 April 2017 at 22:00, Simon Glass <sjg at chromium.org> wrote:
> On 17 April 2017 at 09:48, Philipp Tomsich
> <philipp.tomsich at theobroma-systems.com> wrote:
>> In (first) breaking and (then) fixing the rkspi tool, I realised that
>> the calculation of the required padding (for the header-size and the
>> 2K-in-every-4K SPI layout) was not as self-explainatory as it could
>> have been. This change rewrites the code (using new, common functions
>> in rkcommon.c) and adds verbose in-line comments to ensure that we
>> won't fall into the same pit in the future...
>>
>> Tested on the RK3399 (with has a boot0-style payload) with SD/MMC and SPI.
>>
>> Signed-off-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
>> ---
>>
>> tools/rkcommon.c | 20 ++++++++++++++++++--
>> tools/rkcommon.h | 10 ++++++++--
>> tools/rksd.c | 23 ++++++++++++-----------
>> tools/rkspi.c | 41 +++++++++++++++++++++++++++--------------
>> 4 files changed, 65 insertions(+), 29 deletions(-)
>>
>
> Acked-by: Simon Glass <sjg at chromium.org>

Applied to u-boot-rockchip/next, thanks!


More information about the U-Boot mailing list