[U-Boot] [U-Boot,v2] odroid-c2: Enable distro boot

[Heinrich Schuchardt]

On 04/22/2017 05:47 PM, Andreas Färber wrote:
> Am 22.04.2017 um 16:19 schrieb Heinrich Schuchardt:
>> On 04/22/2017 03:10 PM, Andreas Färber wrote:
>>> Am 22.04.2017 um 14:59 schrieb Heinrich Schuchardt:
>>>> On 01/15/2017 07:52 PM, Andreas Färber wrote:
>>>>> Use the generic "distro" boot framework to enable automatic DHCP boot.
>>>>>
>>>>> The fdt and kernel addresses are adopted from downstream; ramdisk and
>>>>> scriptaddr addresses were chosen arbitrarily.
>>>>>
>>>>> Signed-off-by: Andreas Färber <afaerber at suse.de>
>>>>> ---
>>>> ...
>>>>> diff --git a/include/configs/odroid-c2.h b/include/configs/odroid-c2.h
>>>>> index 1d5b3d5..bf7e1af 100644
>>>>> --- a/include/configs/odroid-c2.h
>>>>> +++ b/include/configs/odroid-c2.h
>>>>> @@ -12,6 +12,8 @@
>>>>>  #define CONFIG_CONS_INDEX		0
>>>>>  #define CONFIG_BAUDRATE			115200
>>>>>  
>>>>> +#define MESON_FDTFILE_SETTING "fdtfile=amlogic/meson-gxbb-odroidc2.dtb\0"
>>>>
>>>> do you remember why you chose to put meson-gxbb-odroidc2.dtb into
>>>> subdirectory amlogic?
>>>
>>> I chose that directory name when I added GXBaby support to the kernel:
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/arch/arm64/boot/dts
>>>
>>> Note that we had a discussion about this a while ago when I sent patches
>>> to amend the distro framework's dtb search paths, and Tom's decision was
>>> to instead hardcode the vendor dirs inside $fdtfile.
>>
>> I am aware that in the Linux Kernel vendor subdirectories are used for
>> arm64 dtbs.
> 
> And therefore that is the expected installation location of the .dtb
> files shipped with the kernel. If your distro wants to differ, you are
> free to compensate with symlinks - which is what has been forced onto us
> with the old situation.
> 
>> I was questioning about U-Boot. I could not find any usage of
>> subdirectories for other arm64 boards:
>>
>> hikey_defconfig: fdtfile=hi6220-hikey.dtb
>> dragonboard410c_defconfig: fdtfile=apq8016-sbc.dtb
>>
>> but
>>
>> odroid-c2_defconfig: fdtfile=amlogic/meson-gxbb-odroidc2.dtb
> 
> I mentioned RPi3:
> 
> board/raspberrypi/rpi/rpi.c:#define DTB_DIR "broadcom/"
> 
> Like I said, patches welcome. HiKey and Dragonboard410c not yet running
> an official JeOS image (cf. my BUD17 talk) may be one reason we haven't
> bothered yet. Also it wasn't clear to me what Tom wanted exactly based
> on his reply, so I never followed up. For sunxi, search the list for
> "fdtfile" in the subject. Need to do some more shopping, so can't help
> you search right now.

I am not on JeOS. I referred to Debian.

This the result for sunxi:
pine64_plus_defconfig: fdtfile=sun50i-a64-pine6-plus.dtb

According doc/README.pxe ftdfile was never meant to contain a path. If
you want a path this should be defined as ftddir.

So Odroid C2 is buggy and we should clean up the fdtfile variable.

Best regards

Heinrich Schuchardt

> 
> Regards,
> Andreas
>