[U-Boot] [PATCH] sf: Fix s25fs512s erase size and remove SECT_4K flag

Jagan Teki jagannadh.teki at gmail.com
Wed Apr 26 07:30:39 UTC 2017


On Tue, Apr 25, 2017 at 2:51 PM, Suresh Gupta <suresh.gupta at nxp.com> wrote:
> As per data sheet, S25FS512S support Uniform sector option
> or erase size of 256 kbytes and Page Programming buffer of
> 256 or 512 Bytes. So, flag SECT_4K have no significance
> for this flash.
>
> Signed-off-by: Suresh Gupta <suresh.gupta at nxp.com>
> ---
>  drivers/mtd/spi/spi_flash_ids.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi/spi_flash_ids.c b/drivers/mtd/spi/spi_flash_ids.c
> index edca94e..7ca33e8 100644
> --- a/drivers/mtd/spi/spi_flash_ids.c
> +++ b/drivers/mtd/spi/spi_flash_ids.c
> @@ -101,7 +101,7 @@ const struct spi_flash_info spi_flash_ids[] = {
>         {"s25fl256s_256k", INFO(0x010219, 0x4d00, 256 * 1024,   128, RD_FULL | WR_QPP) },
>         {"s25fl256s_64k",  INFO(0x010219, 0x4d01,  64 * 1024,   512, RD_FULL | WR_QPP) },
>         {"s25fs256s_64k",  INFO6(0x010219, 0x4d0181, 64 * 1024, 512, RD_FULL | WR_QPP | SECT_4K) },
> -       {"s25fs512s",      INFO6(0x010220, 0x4d0081, 128 * 1024, 512, RD_FULL | WR_QPP | SECT_4K) },
> +       {"s25fs512s",      INFO6(0x010220, 0x4d0081, 256 * 1024, 256, RD_FULL | WR_QPP) },

Did you verify this? because we have an issue about this part number[1]

[1] https://lists.denx.de/pipermail/u-boot/2016-December/276032.html

thanks!
-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.


More information about the U-Boot mailing list