[U-Boot] [PATCH v2 4/6] am33xx: Provide platform data for mmc

[Adam Ford]

On Wed, Apr 26, 2017 at 6:13 AM, Lokesh Vutla <lokeshvutla at ti.com> wrote:
>
>
> On Wednesday 26 April 2017 04:41 PM, Adam Ford wrote:
>> On Wed, Apr 26, 2017 at 3:07 AM, Lokesh Vutla <lokeshvutla at ti.com> wrote:
>>> Signed-off-by: Lokesh Vutla <lokeshvutla at ti.com>
>>> ---
>>> Changes since v1:
>>> - Update base addresses for MMC0 and MMC1
>>>  board/ti/am335x/board.c | 32 ++++++++++++++++++++++++++++++++
>>>  1 file changed, 32 insertions(+)
>>>
>>> diff --git a/board/ti/am335x/board.c b/board/ti/am335x/board.c
>>> index 3e842d3187..6786229680 100644
>>> --- a/board/ti/am335x/board.c
>>> +++ b/board/ti/am335x/board.c
>>> @@ -9,6 +9,7 @@
>>>   */
>>>
>>>  #include <common.h>
>>> +#include <dm.h>
>>>  #include <errno.h>
>>>  #include <spl.h>
>>>  #include <serial.h>
>>> @@ -26,6 +27,7 @@
>>>  #include <asm/emif.h>
>>>  #include <asm/gpio.h>
>>>  #include <asm/omap_sec_common.h>
>>> +#include <asm/omap_mmc.h>
>>>  #include <i2c.h>
>>>  #include <miiphy.h>
>>>  #include <cpsw.h>
>>> @@ -892,3 +894,33 @@ void board_fit_image_post_process(void **p_image, size_t *p_size)
>>>         secure_boot_verify_image(p_image, p_size);
>>>  }
>>>  #endif
>>> +
>>> +#if !CONFIG_IS_ENABLED(OF_CONTROL)
>>> +static const struct omap_hsmmc_plat am335x_mmc0_platdata = {
>>> +       .base_addr = (struct hsmmc *)OMAP_HSMMC1_BASE,
>>> +       .cfg.host_caps = MMC_MODE_HS_52MHz | MMC_MODE_HS | MMC_MODE_4BIT,
>>> +       .cfg.f_min = 400000,
>>> +       .cfg.f_max = 52000000,
>>> +       .cfg.voltages = MMC_VDD_32_33 | MMC_VDD_33_34 | MMC_VDD_165_195,
>>> +       .cfg.b_max = CONFIG_SYS_MMC_MAX_BLK_COUNT,
>>> +};
>>
>> Do you need to address the offset factor here if you're going to
>> rebase from my series?  My series removed the offset from struct hsmmc
>
> OMAP_HSMMC1_BASE includes the offset. This is currently being used in
> driver as well for non-DM cases.

Great!

thanks

>
> Thanks and regards,
> Lokesh
>