[U-Boot] [PATCH 1/6] board: ti: Define Kconfig symbol for common cmd options

Adam Ford aford173 at gmail.com
Thu Apr 27 13:45:42 UTC 2017


On Thu, Apr 27, 2017 at 8:39 AM, Tom Rini <trini at konsulko.com> wrote:
> On Thu, Apr 27, 2017 at 08:21:52AM -0500, Adam Ford wrote:
>> On Thu, Apr 27, 2017 at 7:43 AM, Tom Rini <trini at konsulko.com> wrote:
>> > On Thu, Apr 27, 2017 at 03:43:58PM +0530, Lokesh Vutla wrote:
>> >
>> >> Instead of defining command options in every defconfig,
>> >> define a common Kconfig symbol that consolidates all command
>> >> options that are supported by any TI platform. Also use imply
>> >> keyword so that that specific option can be disabled if
>> >> not required.
>> >>
>> >> Signed-off-by: Lokesh Vutla <lokeshvutla at ti.com>
>> >
>> > Reviewed-by: Tom Rini <trini at konsulko.com>
>>
>> I wonder if it would make sense to make these more generic and put
>> them under the OMAP34XX, OMAP4, ... headings. This way we wouldn't
>> have a bunch of copies for everyone's boards.  I haven't tried it, but
>> I assume that if ou disable the features in the menuconfig and
>> savedefconfig to update the config files it would leave the
>> de-selected items.  I realize that the upfront work might be a little
>> more, but I think it would really clean stuff up.  It's not a request,
>> but just a brainstorming idea.
>
> So, this is something that I've asked TI to make.  The issue here is
> that for all official TI EVMs there is a desire to have a consistent set
> of commands available to the users.  I think that long term, we do need
> to make more things globally be default y as well.  But I see this more
> as being akin to DISTRO_DEFAULTS, in that it's a collection of default
> that a group sees as being important.
>

That makes sense.

thanks

adam
> --
> Tom


More information about the U-Boot mailing list