[U-Boot] [PATCH] sunxi: Explicitly call fdt_fixup_ethernet() in our ft_board_setup()

[Tom Rini]

On Fri, Apr 28, 2017 at 11:37:13AM +0000, Joakim Tjernlund wrote:
> On Fri, 2017-04-28 at 11:05 +0200, Maxime Ripard wrote:
> > On Fri, Apr 28, 2017 at 03:33:53PM +0800, Chen-Yu Tsai wrote:
> > > The sunxi platform relies on the core boot sequence to load and process
> > > device tree blobs, including writing back any MAC addresses we generate
> > > by an implicit call to fdt_fixup_ethernet() within the image loading
> > > mechanism. This call was removed in commit 3f66149d9fb4 ("Remove extra
> > > fdt_fixup_ethernet() call"), resuling in Linux using random MAC
> > > addresses.
> > > 
> > > This patch adds an explicit call to fdt_fixup_ethernet() in our
> > > ft_board_setup() function.
> > > 
> > > Fixes: 3f66149d9fb4 ("Remove extra fdt_fixup_ethernet() call")
> > 
> > I would just revert that commit. The function mentionned in the commit
> > log is platform specific, it just doesn't make any sense to remove
> > some generic code just because it would work on your platform.
> 
> The Generic code was both added later and wrong so no need to restore that.
> 
> One could remove the platform specific code and add back a generic one but then
> make sure it is called BEFORE any board setup.

OK, let me see if I can come up with something then, test patch shortly.

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170428/a0e58785/attachment.sig>