[U-Boot] [PATCH] rockchip: video: introduce CONFIG_DESIGNWARE_HDMI and select for Rockchip HDMI

[Simon Glass]

Hi Philipp,

On 28 April 2017 at 08:55, Philipp Tomsich
<philipp.tomsich at theobroma-systems.com> wrote:
> Instead of having drivers/video/rockchip/Kconfig point outside of its
> hierarchy for dw_hdmi.o, we should use a configuration-option to
> include the Designware HDMI support.
>
> This change introduces a new config option (not to be selected via
> menuconfig, but to be selected from a dependent video driver's
> configuration option) that enables dw_hdmi.o and selects it whenever
> the HDMI support for Rockchip SoCs is selected.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
> ---
>
>  drivers/video/Kconfig           | 9 +++++++++
>  drivers/video/Makefile          | 1 +
>  drivers/video/rockchip/Kconfig  | 1 +
>  drivers/video/rockchip/Makefile | 2 +-
>  4 files changed, 12 insertions(+), 1 deletion(-)

Reviewed-by: Simon Glass <sjg at chromium.org>


>
> diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
> index 818f738..c629c6e 100644
> --- a/drivers/video/Kconfig
> +++ b/drivers/video/Kconfig
> @@ -610,4 +610,13 @@ config LCD
>           CONFIG option. See the README for details. Drives which have been
>           converted to driver model will instead used CONFIG_DM_VIDEO.
>
> +config DESIGNWARE_HDMI

How about VIDEO_DW_HDMI for this?

We seem to use a similar thing with MMC and USB

> +       bool
> +       help
> +         Enables the common driver code for the Designware HDMI TX
> +         block found in SoCs from various vendors.
> +         As this does not provide any functionality by itself (but
> +         rather requires a SoC-specific glue driver to call it), it
> +         can not be enabled from the configuration menu.
> +
>  endmenu
> diff --git a/drivers/video/Makefile b/drivers/video/Makefile
> index 7cd6d28..f06aaf6 100644
> --- a/drivers/video/Makefile
> +++ b/drivers/video/Makefile
> @@ -58,6 +58,7 @@ obj-$(CONFIG_VIDEO_VESA) += vesa.o
>  obj-$(CONFIG_FORMIKE) += formike.o
>  obj-$(CONFIG_LG4573) += lg4573.o
>  obj-$(CONFIG_AM335X_LCD) += am335x-fb.o
> +obj-$(CONFIG_DESIGNWARE_HDMI) += dw_hdmi.o
>
>  obj-${CONFIG_VIDEO_TEGRA124} += tegra124/
>  obj-${CONFIG_EXYNOS_FB} += exynos/
> diff --git a/drivers/video/rockchip/Kconfig b/drivers/video/rockchip/Kconfig
> index d94afbd..938409d 100644
> --- a/drivers/video/rockchip/Kconfig
> +++ b/drivers/video/rockchip/Kconfig
> @@ -35,6 +35,7 @@ config DISPLAY_ROCKCHIP_LVDS
>
>  config DISPLAY_ROCKCHIP_HDMI
>         bool "HDMI port"
> +       select DESIGNWARE_HDMI
>         depends on VIDEO_ROCKCHIP
>         help
>           This enables High-Definition Multimedia Interface display support.
> diff --git a/drivers/video/rockchip/Makefile b/drivers/video/rockchip/Makefile
> index 3bb0519..3d376d5 100644
> --- a/drivers/video/rockchip/Makefile
> +++ b/drivers/video/rockchip/Makefile
> @@ -9,5 +9,5 @@ ifdef CONFIG_VIDEO_ROCKCHIP
>  obj-y += rk_vop.o
>  obj-$(CONFIG_DISPLAY_ROCKCHIP_EDP) += rk_edp.o
>  obj-$(CONFIG_DISPLAY_ROCKCHIP_LVDS) += rk_lvds.o
> -obj-$(CONFIG_DISPLAY_ROCKCHIP_HDMI) += rk_hdmi.o ../dw_hdmi.o
> +obj-$(CONFIG_DISPLAY_ROCKCHIP_HDMI) += rk_hdmi.o
>  endif
> --
> 1.9.1
>

Regards,
Simon