[U-Boot] [PATCH v3 11/24] env: Create a location driver for each location

[Simon Glass]

Hi Tom,

On 26 July 2017 at 11:46, Tom Rini <trini at konsulko.com> wrote:
> On Wed, Jul 26, 2017 at 11:19:35AM -0600, Simon Glass wrote:
>
>> Set up a location driver for each supported environment locatoin. At
>> present this just points to the global functions and is not used. A
>> later patch will switch this over to use private functions in each driver.
>>
>> Signed-off-by: Simon Glass <sjg at chromium.org>
> [snip]
>> +#ifdef CONFIG_SPL_BUILD
>> +/* TODO(sjg at chromium.org): Figure out why this is needed */
>> +# if !defined(CONFIG_TARGET_AM335X_EVM) || defined(CONFIG_SPL_OS_BOOT)
>> +#  define LOADENV
>> +# endif
>> +#else
>> +# define LOADENV
>> +# if defined(CONFIG_CMD_SAVEENV)
>> +#  define CMD_SAVEENV
>> +# endif
>> +#endif
>
> I know you couldn't spin around on this quickly, but please let me know
> if this is still a problem after the short series I posted, and if so
> hit me up off-list with a branch I can pull and poke at here.  I'd like
> to get this, and the other TODOs in this patch sorted out.  Thanks!

I added notes to the commit message on v4. Yes there is still a
problem - one of the patches broke building for me. I think it needs
another look.

Regards,
Simon