[U-Boot] [PATCH v2 10/22] x86: kconfig: Imply DM uclass drivers
Bin Meng
bmeng.cn at gmail.com
Tue Aug 1 12:23:12 UTC 2017
On Tue, Aug 1, 2017 at 5:12 PM, Simon Glass <sjg at chromium.org> wrote:
> On 30 July 2017 at 07:23, Bin Meng <bmeng.cn at gmail.com> wrote:
>> Now that all x86 boards have been converted to use DM, we can imply
>> these uclass drivers (DM_ETH, DM_RTC, DM_USB, DM_VIDEO) from the
>> top level.
>>
>> Previously DM_GPIO, DM_KEYBOARD, DM_SERIAL, DM_SPI, DM_SPI_FLASH
>> are selected. Change to use 'imply' to allow them to be removed.
>>
>> Note with this change, chromebook_link64 build fails:
>>
>> common/built-in.o:(.data.env_htab+0xc): undefined reference to 'env_flags_validate'
>> lib/built-in.o: In function `hsearch_r':
>> lib/hashtable.c:380: undefined reference to 'env_callback_init'
>> lib/hashtable.c:382: undefined reference to 'env_flags_init'
>> make[1]: *** [spl/u-boot-spl] Error 1
>>
>> CONFIG_SPL_ENV_SUPPORT is required for chromebook_link64 to build
>> again. This is just a workaround as it is not needed at all. See
>> commit bda40d5 "x86: qemu: Add a config for 64-bit U-Boot" for
>> the same issue seen on QEMU 64-bit target.
>>
>> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
>> Reviewed-by: Andy Shevchenko <andy.shevchenko at gmail.com>
>> ---
>>
>> Changes in v2: None
>>
>> arch/Kconfig | 16 ++++++++++------
>> configs/bayleybay_defconfig | 4 ----
>> configs/chromebook_link64_defconfig | 4 +---
>> configs/chromebook_link_defconfig | 3 ---
>> configs/chromebook_samus_defconfig | 3 ---
>> configs/chromebox_panther_defconfig | 4 ----
>> configs/conga-qeval20-qa3-e3845-internal-uart_defconfig | 4 ----
>> configs/conga-qeval20-qa3-e3845_defconfig | 4 ----
>> configs/coreboot-x86_defconfig | 4 ----
>> configs/cougarcanyon2_defconfig | 3 ---
>> configs/crownbay_defconfig | 4 ----
>> configs/dfi-bt700-q7x-151_defconfig | 4 ----
>> configs/edison_defconfig | 1 -
>> configs/efi-x86_defconfig | 3 +--
>> configs/galileo_defconfig | 4 ----
>> configs/minnowmax_defconfig | 4 ----
>> configs/qemu-x86_64_defconfig | 4 ----
>> configs/qemu-x86_defconfig | 4 ----
>> configs/qemu-x86_efi_payload32_defconfig | 4 ----
>> configs/qemu-x86_efi_payload64_defconfig | 4 ----
>> configs/som-db5800-som-6867_defconfig | 4 ----
>> configs/theadorable-x86-dfi-bt700_defconfig | 4 ----
>> 22 files changed, 12 insertions(+), 81 deletions(-)
>
> Reviewed-by: Simon Glass <sjg at chromium.org>
applied to u-boot-x86, thanks!
More information about the U-Boot
mailing list