[U-Boot] [PATCH 2/9] fit: use 'const' for the input of fdt_offset() and locate_dtb_in_fit()

Simon Glass sjg at chromium.org
Thu Aug 3 15:24:59 UTC 2017


On 20 July 2017 at 11:02, Jean-Jacques Hiblot <jjhiblot at ti.com> wrote:
> Those 2 functions don't modify their input, we can mark it const.
> This prevents compilation warnings when they are provided const input.
>
> Signed-off-by: Jean-Jacques Hiblot <jjhiblot at ti.com>
> ---
>  common/boot_fit.c  | 4 ++--
>  include/boot_fit.h | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>

Reviewed-by: Simon Glass <sjg at chromium.org>

Please see below.

> diff --git a/common/boot_fit.c b/common/boot_fit.c
> index 51440a6..6fdf019 100644
> --- a/common/boot_fit.c
> +++ b/common/boot_fit.c
> @@ -13,7 +13,7 @@
>  #include <image.h>
>  #include <libfdt.h>
>
> -int fdt_offset(void *fit)
> +int fdt_offset(const void *fit)
>  {
>         int images, node, fdt_len, fdt_node, fdt_offset;
>         const char *fdt_name;
> @@ -55,7 +55,7 @@ int fdt_offset(void *fit)
>         return fdt_offset;
>  }
>
> -void *locate_dtb_in_fit(void *fit)
> +void *locate_dtb_in_fit(const void *fit)
>  {
>         struct image_header *header;
>         int size;
> diff --git a/include/boot_fit.h b/include/boot_fit.h
> index b7d2462..3d6996a 100644
> --- a/include/boot_fit.h
> +++ b/include/boot_fit.h
> @@ -5,5 +5,5 @@
>   * SPDX-License-Identifier:     GPL-2.0+
>   */
>
> -int fdt_offset(void *fit);
> -void *locate_dtb_in_fit(void *fit);
> +int fdt_offset(const void *fit);
> +void *locate_dtb_in_fit(const void *fit);

Can you please add comments here for these two functions?

> --
> 1.9.1
>


More information about the U-Boot mailing list