[U-Boot] [PATCH] drivers: mmc: Avoid memory leak in case of failure

Suniel Mahesh sunil.m at techveda.org
Fri Aug 4 09:34:13 UTC 2017


On Monday 17 July 2017 04:38 PM, Jaehoon Chung wrote:
> On 06/20/2017 01:53 AM, sunil.m at techveda.org wrote:
>> From: Suniel Mahesh <sunil.m at techveda.org>
>>
>> priv pointer should be freed before returning with an error value
>> from exynos_dwmci_get_config().
>>
>> Signed-off-by: Suniel Mahesh <sunil.m at techveda.org>
>> Signed-off-by: Raghu Bharadwaj <raghu at techveda.org>
> 
> Applied to u-boot-mmc.

Hi, It says the patch has been applied to u-boot-mmc git tree,
but I couldn't find it there applied.
http://git.denx.de/?p=u-boot/u-boot-mmc.git;a=summary

are there any issues with the patch or am I looking at the wrong place ? 

Thanks
suniel

> 
> Best Regards,
> Jaehoon Chung
>> ---
>>  drivers/mmc/exynos_dw_mmc.c | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/mmc/exynos_dw_mmc.c b/drivers/mmc/exynos_dw_mmc.c
>> index 40f7892..84ef2da 100644
>> --- a/drivers/mmc/exynos_dw_mmc.c
>> +++ b/drivers/mmc/exynos_dw_mmc.c
>> @@ -168,6 +168,7 @@ static int exynos_dwmci_get_config(const void *blob, int node,
>>  
>>  	if (host->dev_index > 4) {
>>  		printf("DWMMC%d: Can't get the dev index\n", host->dev_index);
>> +		free(priv);
>>  		return -EINVAL;
>>  	}
>>  
>> @@ -178,6 +179,7 @@ static int exynos_dwmci_get_config(const void *blob, int node,
>>  	base = fdtdec_get_addr(blob, node, "reg");
>>  	if (!base) {
>>  		printf("DWMMC%d: Can't get base address\n", host->dev_index);
>> +		free(priv);
>>  		return -EINVAL;
>>  	}
>>  	host->ioaddr = (void *)base;
>> @@ -187,6 +189,7 @@ static int exynos_dwmci_get_config(const void *blob, int node,
>>  	if (err) {
>>  		printf("DWMMC%d: Can't get sdr-timings for devider\n",
>>  				host->dev_index);
>> +		free(priv);
>>  		return -EINVAL;
>>  	}
>>  
>>
> 



More information about the U-Boot mailing list