[U-Boot] [PATCH 1/3] spl: add hierarchical defaults for SPL_LDSCRIPT

Simon Glass sjg at chromium.org
Sun Aug 6 05:17:20 UTC 2017


Hi Philipp,

On 4 August 2017 at 14:52, Philipp Tomsich
<philipp.tomsich at theobroma-systems.com> wrote:
> With SPL_LDSCRIPT moved to Kconfig (and this being a 'string' config
> node), all the lingering definitions in header files will cause errors
> due to the redefinition of the configuration item.
>
> As we don't want to pollute the defconfig files (and values should
> usually be identical for entire architectures), the defaults are moved
> into Kconfig.  Kconfig will always pick the first default that
> matches, so please keep these values at the end of each file (to allow
> any board-specific Kconfig, which will be included earlier) to
> override with an unconditional default setting.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich at theobroma-systems.com>
>
> ---
>
>  arch/arm/Kconfig                          | 12 ++++++++++++
>  arch/arm/cpu/armv8/fsl-layerscape/Kconfig |  3 +++
>  arch/arm/mach-at91/Kconfig                |  4 ++++
>  arch/arm/mach-davinci/Kconfig             |  4 ++++
>  arch/arm/mach-exynos/Kconfig              |  3 +++
>  arch/arm/mach-omap2/Kconfig               |  3 +++
>  arch/arm/mach-orion5x/Kconfig             |  3 +++
>  arch/arm/mach-sunxi/Kconfig               |  3 +++
>  arch/arm/mach-zynq/Kconfig                |  3 +++
>  arch/microblaze/Kconfig                   |  3 +++
>  board/armadeus/apf27/Kconfig              |  3 +++
>  board/freescale/mx31pdk/Kconfig           |  3 +++
>  board/spear/x600/Kconfig                  |  3 +++
>  13 files changed, 50 insertions(+)
>

Reviewed-by: Simon Glass <sjg at chromium.org>

I would expect this to generate warnings given that the header files
define these also. But perhaps it doesn't since the values are the
same.


More information about the U-Boot mailing list