[U-Boot] [PATCH] sunxi: Fix CONFIG_SUNXI_GMAC references

Mark Kettenis mark.kettenis at xs4all.nl
Mon Aug 7 09:58:49 UTC 2017


> X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on lists.denx.de
> X-Spam-Level: 
> X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=unavailable
> 	autolearn_force=no version=3.4.0
> Date: Mon, 7 Aug 2017 11:35:52 +0200 (CEST)
> From: Mark Kettenis <mark.kettenis at xs4all.nl>
> Cc: albert.u.boot at aribaud.net, jernej.skrabec at siol.net, u-boot at lists.denx.de,
>         andre.przywara at arm.com, hdegoede at redhat.com, icenowy at aosc.xyz,
>         maxime.ripard at free-electrons.com, jagan at openedev.com, afaerber at suse.de
> Sender: "U-Boot" <u-boot-bounces at lists.denx.de>
> X-XS4ALL-DNSBL-Checked: mxdrop302.xs4all.net checked 81.169.180.215 against DNS blacklists
> X-CNFS-Analysis: v=2.2 cv=V9A/6qvi c=1 sm=0 tr=0
>  a=ONADgqKa62I6zSSZ3CeWOA==:117 a=ONADgqKa62I6zSSZ3CeWOA==:17
>  a=IkcTkHD0fZMA:10 a=xqWC_Br6kY4A:10 a=KeKAF7QvOSUA:10 a=WiVod9pSvdkA:10
>  a=pGLkceISAAAA:8 a=cm27Pg_UAAAA:8 a=yTmaW2WvAAAA:8 a=8flm3ZimAAAA:8
>  a=3tcz3bTJAAAA:8 a=YfCOm-DyAAAA:8 a=ulZhkHzn2l8uUku_rLcA:9 a=QEXdDO2ut3YA:10
>  a=6kGIvZw6iX1k4Y-7sg4_:22 a=xmb-EsYY8bH0VWELuYED:22
>  a=JtT7V0wkIbYGGTrklAfD:22 a=bqseOZt422ZGMqA63K3A:22
>  a=4EbjBm0RLgFgoQzmu6QD:22 a=zQLMK8awuJ6_Hvp-_9Ux:22
> X-Virus-Scanned: by XS4ALL Virus Scanner
> X-XS4ALL-Spam-Score: -0.5 () RP_MATCHES_RCVD, T_HEADER_FROM_DIFFERENT_DOMAINS
> X-XS4ALL-Spam: NO
> Envelope-To: mark.kettenis at xs4all.nl
> X-MIME-Autoconverted: from base64 to 8bit by sibelius.xs4all.nl id v779cZ2M003524
> 
> > From: Jagan Teki <jagannadh.teki at gmail.com>
> > Date: Mon, 7 Aug 2017 14:56:58 +0530
> > 
> > On Sun, Aug 6, 2017 at 10:45 AM, Simon Glass <sjg at chromium.org> wrote:
> > > On 26 July 2017 at 05:26, Dave Prue <dave at prue.com> wrote:
> > >> GMAC Initialization for sun7i targets has been broken since v2017.05-rc3
> > >> due to the renaming of CONFIG_SUNXI_GMAC to CONFIG_SUN7I_GMAC in Kconfig
> > >> without propogating the name change throughout the code.
> > >>
> > >> Signed-off-by: Dave Prue <dave at prue.com>
> > >> ---
> > >>
> > >>  arch/arm/include/asm/arch-sunxi/sys_proto.h | 2 +-
> > >>  board/sunxi/Makefile                        | 2 +-
> > >>  include/configs/sunxi-common.h              | 2 +-
> > >>  scripts/build-whitelist.sh                  | 2 +-
> > >>  scripts/config_whitelist.txt                | 2 +-
> > >>  5 files changed, 5 insertions(+), 5 deletions(-)
> > >
> > > Reviewed-by: Simon Glass <sjg at chromium.org>
> > 
> > Reviewed-by: Jagan Teki <jagan at openedev.com>
> 
> And makes the interface work again under OpenBSD, so:
> 
> Reviewed-by: Mark Kettenis <kettenis at openbsd.org>
> Tested-by: Mark Kettenis <kettenis at openbsd.org>

Actually the scripts/build-whitelist.sh change isn't right.  It should
also either be dropped or SUNXI_GMAC on the line above should be
changed into SUN7I_GMAC.  It's in a comment, but with the change the
comment doesn't make sense anymore ;).


More information about the U-Boot mailing list