[U-Boot] [PATCH 1/1] board/ls2081ardb: Some updates like flash type

York Sun york.sun at nxp.com
Mon Aug 7 21:06:13 UTC 2017


Santan,

Please rephrase your subject. It is too vague, probably because you are 
making unrelated changes in one patch.

On 06/23/2017 03:08 AM, Santan Kumar wrote:
> Patch makes below changes:
> -Update QSPI flash type
> 	As per updated board design,
> 	different QSPI flash is connected on boards,
> 	hence change QSPI flash type from
> 	Micron n25q512a device to spansion s25fs512s
> 	device in dts and config.
> -Update QIXIS_QMAP_MASK value from 0x07 to 0x70

Was it wrong before? What's the symptom?

> -Update checkboard()
> 	display of boot source and board information

This is not what your change does.

> -Correct DSPI flash config selection
> -Remove deprecated config : CONFIG_DISPLAY_BOARDINFO_LATE

Please rework your commit message. It is there to explain why you make 
the changes, not only what you  do. It is not a slide show. Please write 
in paragraphs, and wrap back at or before 70 characters.

Please separate your patch to make it do logically one thing in a patch.

> 
> Signed-off-by: Santan Kumar <santan.kumar at nxp.com>
> Signed-off-by: Yogesh Gaur <yogeshnarayan.gaur at nxp.com>
> Signed-off-by: Priyanka Jain <priyanka.jain at nxp.com>
> ---
> This patch is split version of another patch
>   https://emea01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fpatch%2F773670%2F&data=01%7C01%7Cyork.sun%40nxp.com%7Ce620c3f6c991446d58cd08d4ba1fba19%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0&sdata=TqaRlYcYT2NtQWFfPYy7sMC5DpghSD%2BA4EgaqSFe0W0%3D&reserved=0
> 

Don't see how it is split in this patch.

York


More information about the U-Boot mailing list