[U-Boot] [PATCH 1/1] board/ls2080ardb: Disable SD-related GPIO programming

[Priyanka Jain]

> -----Original Message-----
> From: York Sun
> Sent: Tuesday, August 08, 2017 2:20 AM
> To: Priyanka Jain <priyanka.jain at nxp.com>; Santan Kumar
> <santan.kumar at nxp.com>; u-boot at lists.denx.de
> Subject: Re: [PATCH 1/1] board/ls2080ardb: Disable SD-related GPIO
> programming
> 
> On 06/20/2017 11:54 PM, Priyanka Jain wrote:
> >
> >
> >> -----Original Message-----
> >> From: York Sun
> >> Sent: Wednesday, June 14, 2017 2:16 AM
> >> To: Santan Kumar <santan.kumar at nxp.com>; u-boot at lists.denx.de
> >> Cc: Priyanka Jain <priyanka.jain at nxp.com>
> >> Subject: Re: [PATCH 1/1] board/ls2080ardb: Disable SD-related GPIO
> >> programming
> >>
> >> On 06/08/2017 11:16 PM, Santan Kumar wrote:
> >>> LS2080ARDB/LS2088ARDB updated RevF boards do not have smart voltage
> >>> translator, so no need to program GPIO for LS2088ARDB boards The
> >>> GPIO programming is required only for LS2081ARDB.
> >>>
> >>> Signed-off-by: Santan Kumar <santan.kumar at nxp.com>
> >>> Signed-off-by: Priyanka Jain <priyanka.jain at nxp.com>
> >>> ---
> >>>    board/freescale/ls2080ardb/ls2080ardb.c | 18 ++----------------
> >>>    1 file changed, 2 insertions(+), 16 deletions(-)
> >>>
> >>> diff --git a/board/freescale/ls2080ardb/ls2080ardb.c
> >>> b/board/freescale/ls2080ardb/ls2080ardb.c
> >>> index df2d768..210142c 100644
> >>> --- a/board/freescale/ls2080ardb/ls2080ardb.c
> >>> +++ b/board/freescale/ls2080ardb/ls2080ardb.c
> >>> @@ -257,31 +257,17 @@ int board_early_init_f(void)
> >>>
> >>>    int misc_init_r(void)
> >>>    {
> >>> -#ifdef CONFIG_FSL_QIXIS
> >>> -	/*
> >>> -	 * LS2081ARDB has smart voltage translator which needs
> >>> -	 * to be programmed as below
> >>> -	 */
> >>> -#ifndef CONFIG_TARGET_LS2081ARDB
> >>> -	u8 sw;
> >>> -
> >>> -	sw = QIXIS_READ(arch);
> >>>    	/*
> >>> -	 * LS2080ARDB/LS2088ARDB RevF board has smart voltage translator
> >>> +	 * LS2081ARDB RevF board has smart voltage translator
> >>>    	 * which needs to be programmed to enable high speed SD interface
> >>>    	 * by setting GPIO4_10 output to zero
> >>>    	 */
> >>> -	if ((sw & 0xf) == 0x5) {
> >>> -#endif
> >>> +#ifdef CONFIG_TARGET_LS2081ARDB
> >>>    		out_le32(GPIO4_GPDIR_ADDR, (1 << 21 |
> >>>    					    in_le32(GPIO4_GPDIR_ADDR)));
> >>>    		out_le32(GPIO4_GPDAT_ADDR, (~(1 << 21) &
> >>>    					    in_le32(GPIO4_GPDAT_ADDR))); -
> >> #ifndef
> >>> CONFIG_TARGET_LS2081ARDB
> >>> -	}
> >>> -#endif
> >>>    #endif
> >>> -
> >>>    	if (hwconfig("sdhc"))
> >>>    		config_board_mux(MUX_TYPE_SDHC);
> >>>
> >>>
> >>
> >> This change is not backward-compatible, is it?
> >>
> >> York
> > Yes, It is backward compatible. As per updated board designs and the
> manufactured boards, GPIO programming is required only for LS2081ARDB
> boards.
> 
> Priyanka,
> 
> I looked at this patch again. Before this change, LS2080ARDB rev F and
> LS2081ARDB both have the smart voltage translator enabled. After this change,
> rev F no longer enables this voltage translator. You still consider it backward-
> compatible?
> 
> York

Both LS2080ARDB rev F and LS2081ARDB were initially designed to have smart voltage translator to support SD-boot and UHS mode 
At a later stage, due to some issues on LS2088ARDB RevF board to support SD-boot, translator was removed from RevF boards.

I confirmed with board team that all LS2088ARDB RevF board will not have the smart voltage translator and all LS2081ARDB boards will have smart voltage translator.

Priyanka