[U-Boot] [PATCH] x86: acpi: Fix build error with certain configuration

Stefan Roese sr at denx.de
Tue Aug 8 11:44:24 UTC 2017


On 08.08.2017 13:35, Bin Meng wrote:
> When CONFIG_EFI_PARTITION is not set, the following build error is
> seen in arch/x86/lib/acpi_s3.c:
> 
>    error: expected declaration specifiers or '...' before '*' token
>    static void asmlinkage (*acpi_do_wakeup)(void *vector) = (void*)WAKEUP_BASE;
> 
> This is actually caused by missing asmlinkage declaration, but with
> CONFIG_EFI_PARTITION on, the declaration comes from part.h which
> is included from common.h.
> 
> Signed-off-by: Bin Meng <bmeng.cn at gmail.com>
> ---
> 
>   arch/x86/lib/acpi_s3.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/lib/acpi_s3.c b/arch/x86/lib/acpi_s3.c
> index 3175da8..182379b 100644
> --- a/arch/x86/lib/acpi_s3.c
> +++ b/arch/x86/lib/acpi_s3.c
> @@ -8,6 +8,7 @@
>   #include <asm/acpi_s3.h>
>   #include <asm/acpi_table.h>
>   #include <asm/post.h>
> +#include <linux/linkage.h>
>   
>   DECLARE_GLOBAL_DATA_PTR;
>   
> 

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan


More information about the U-Boot mailing list