[U-Boot] [PATCH 1/1] arm: mvebu: avoid possible NULL dereference

[Stefan Roese]

On 30.07.2017 20:40, Heinrich Schuchardt wrote:
> It does not make sense to check if info is NULL after
> dereferencing it.
> 
> The problem was indicated by cppcheck.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> ---
>   arch/arm/mach-mvebu/serdes/axp/high_speed_env_lib.c | 10 +++++-----
>   1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/mach-mvebu/serdes/axp/high_speed_env_lib.c b/arch/arm/mach-mvebu/serdes/axp/high_speed_env_lib.c
> index b0e193b78c..525576a4fc 100644
> --- a/arch/arm/mach-mvebu/serdes/axp/high_speed_env_lib.c
> +++ b/arch/arm/mach-mvebu/serdes/axp/high_speed_env_lib.c
> @@ -354,16 +354,16 @@ int serdes_phy_config(void)
>   	}
>   
>   	info = board_serdes_cfg_get(PEX_MODE_GET(satr11));
> -	DEBUG_INIT_FULL_S("info->line0_7= 0x");
> -	DEBUG_INIT_FULL_D(info->line0_7, 8);
> -	DEBUG_INIT_FULL_S("   info->line8_15= 0x");
> -	DEBUG_INIT_FULL_D(info->line8_15, 8);
> -	DEBUG_INIT_FULL_S("\n");
>   
>   	if (info == NULL) {
>   		DEBUG_INIT_S("Hight speed PHY Error #1\n");
>   		return MV_ERROR;
>   	}
> +	DEBUG_INIT_FULL_S("info->line0_7= 0x");
> +	DEBUG_INIT_FULL_D(info->line0_7, 8);
> +	DEBUG_INIT_FULL_S("   info->line8_15= 0x");
> +	DEBUG_INIT_FULL_D(info->line8_15, 8);
> +	DEBUG_INIT_FULL_S("\n");
>   
>   	if (config_module & ETM_MODULE_DETECT) {	/* step 0.9 ETM */
>   		DEBUG_INIT_FULL_S("ETM module detect Step 0.9:\n");
> 

Reviewed-by: Stefan Roese <sr at denx.de>

Thanks,
Stefan