[U-Boot] [PATCH] ls1046aqds: update the defaule mtdparts

[York Sun]

On 08/07/2017 07:48 PM, Xiaowei Bao wrote:
> Hi York,
> 
> This patch is for the ls1046aqds platform, In order to facilitate the test staff and customers to view the detailed partition information, so didn't define a larger partition to include all images, and the partition rule  is discussed internally as the default partitioning standard for the layerscape platform.

If you start to partition flashes by every image, are you going to do 
the same for QSPI?

> 
> thanks
> 
> -----Original Message-----
> From: York Sun
> Sent: Tuesday, August 08, 2017 6:31 AM
> To: Xiaowei Bao <xiaowei.bao at nxp.com>; Mingkai Hu <mingkai.hu at nxp.com>; Sumit Garg <sumit.garg at nxp.com>; u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH] ls1046aqds: update the defaule mtdparts
> 
> On 07/12/2017 04:44 AM, xiaowei.bao wrote:
>> From: Bao Xiaowei <xiaowei.bao at nxp.com>
>>
>> modify the include/configs/ls1046aqds.h file, according to the latest
>> partion rules, norflash nandflash dspiflash detailed partion as follows:
>>
>> mtd0: 00100000 00020000 "nor_bank0_rcw"
>> mtd1: 00200000 00020000 "nor_bank0_uboot"
>> mtd2: 00100000 00020000 "nor_bank0_uboot_env"
>> mtd3: 00200000 00020000 "nor_bank0_ppa"
>> mtd4: 00300000 00020000 "nor_bank0_secure_boot"
>> mtd5: 00600000 00020000 "nor_bank0_dppa_qe"
>> mtd6: 00100000 00020000 "nor_bank0_dtb"
>> mtd7: 01000000 00020000 "nor_bank0_kernel"
>> mtd8: 02000000 00020000 "nor_bank0_rootfs"
>> mtd9: 00100000 00020000 "nor_bank4_rcw"
>> mtd10: 00200000 00020000 "nor_bank4_uboot"
>> mtd11: 00200000 00020000 "nor_bank4_uboot_env"
>> mtd12: 00100000 00020000 "nor_bank4_ppa"
>> mtd13: 00300000 00020000 "nor_bank4_secure_boot"
>> mtd14: 00600000 00020000 "nor_bank4_dppa_qe"
>> mtd15: 00100000 00020000 "nor_bank4_dtb"
>> mtd16: 01000000 00020000 "nor_bank4_kernel"
>> mtd17: 02000000 00020000 "nor_bank4_rootfs"

When you boot from bank4, your partition name will not match the 
physical bank.

>> mtd18: 00100000 00040000 "nand_rcw"
>> mtd19: 00200000 00040000 "nand_uboot"
>> mtd20: 00100000 00040000 "nand_uboot_env"
>> mtd21: 00200000 00040000 "nand_ppa"
>> mtd22: 00300000 00040000 "nand_secure_boot"
>> mtd23: 00600000 00040000 "nand_dppa_qe"
>> mtd24: 00100000 00040000 "nand_dtb"
>> mtd25: 01000000 00040000 "nand_kernel"
>> mtd26: 02000000 00040000 "nand_rootfs"
>> mtd27: 1c000000 00040000 "nand_free"
>> mtd28: 01000000 00010000 "spi0_free"
>> mtd29: 00080000 00001000 "spi1_free"
>> mtd30: 00800000 00001000 "spi2_free"
> 
> Do we really need to expose every image as individual partition? It is only useful if we need to access them under Linux. What's the chance to update U-Boot environmental variables under Linux? If you really to do so, you can probably be fine by defining a larger partition to include all images used for U-Boot. Agree?

My point is, who uses these partitions? If it is only for testing, you 
can keep this variable local, or leave it to your test script. You are 
not going to use default values of ipaddr, or serverip, are you? Why do 
you rely on the default value of mtdparts? It doesn't even get used by 
U-Boot itself.

York