[U-Boot] [U-Boot, v4, 60/66] rockchip: Kconfig: preset TPL_LDSCRIPT via Kconfig for the RK3368

[Masahiro Yamada]

Hi.


2017-08-07 23:05 GMT+09:00 Tom Rini <trini at konsulko.com>:
> On Mon, Aug 07, 2017 at 10:48:12AM +0200, Dr. Philipp Tomsich wrote:
>> +Tom
>>
>> Ok, so the problem is 'scripts/setlocalversion’, which does the following:
>> > if test -e include/config/auto.conf; then
>> >         . include/config/auto.conf
>> > else
>> >         echo "Error: kernelrelease not valid - run 'make prepare' to update it"
>> >         exit 1
>> > fi
>> in order to access the variables needed for:
>> > # CONFIG_LOCALVERSION and LOCALVERSION (if set)
>> > res="${res}${CONFIG_LOCALVERSION}${LOCALVERSION}"
>> >
>> > # scm version string if not at a tagged commit
>> > if test "$CONFIG_LOCALVERSION_AUTO" = "y"; then
>> >         # full scm version string
>> >         res="$res$(scm_version)"
>> > else
>> >         # append a plus sign if the repository is not in a clean
>> >         # annotated or signed tagged state (as git describe only
>> >         # looks at signed or annotated tags - git tag -a/-s) and
>> >         # LOCALVERSION= is not specified
>> >         if test "${LOCALVERSION+set}" != "set"; then
>> >                 scm=$(scm_version --short)
>> >                 res="$res${scm:++}"
>> >         fi
>> > fi
>>
>> So nothing wrong with the changes to Kconfig, but we’re triggering a weakness in our
>> build infrastructure here.
>>
>> I guess we’ll have to implement a save version of scripts/localversion that does not
>> allow for the execution of arbitrary script code from auto.conf ...
>
> Masahiro, do you have any ideas here?  Thanks!


I do not like $(ARCH) or $(BOARD) in CONFIG values.
How hard is it to describe lds paths verbatim?




-- 
Best Regards
Masahiro Yamada