[U-Boot] [PATCH v3 1/2] usb: net: Add support for Microchip LAN75xx and LAN78xx

Marek Vasut marex at denx.de
Thu Aug 10 07:15:42 UTC 2017


On 08/09/2017 07:47 PM, Joe Hershberger wrote:
> On Wed, Aug 9, 2017 at 12:12 PM, Marek Vasut <marex at denx.de> wrote:
>> On 08/09/2017 06:25 PM, yuiko.oshino at microchip.com wrote:
>>> From: Yuiko Oshino <yuiko.oshino at microchip.com>
>>>
>>> Series-Changes: 3
>>
>> FYI, this will end in the commit message when applied, remove it or move
>> it below the --- . Also commit message is missing.
> 
> This is what I was talking about when I said I would fix the commit
> log as I apply it.

I have a few more comments though, but feel free to fix them up too.

>>>    - All #ifdef CONFIG_DM_ETH and #endif are removed.
>>>    - The lan7x_eth_recv() is modifed to correctly support the Driver Model
>>>      and returns packet_en.
>>>    - Add mii_resolve_flowctrl_fdx() patch in the series.
>>>
>>> Series-Changes: 2
>>>    - The wait_for_bit functions copy the real one.
>>>    - Uses phylib
>>>    - Unnecessary variables are removed
>>>    - All return values are checked
>>>    - Uses mii_resolve_flowctrl_fdx() from linux/mii.h
>>>
>>> Signed-off-by: Yuiko Oshino <yuiko.oshino at microchip.com>
>>> ---
>>> Add support for Microchip LAN7500, LAN7800 and LAN7850,
>>> USB to 10/100/1000 Ethernet Controllers.
>>>


-- 
Best regards,
Marek Vasut


More information about the U-Boot mailing list