[U-Boot] [PATCH v1 4/7] cmd: add sdp command

[Stefano Babic]

Hi Stefan,

On 05/08/2017 01:38, Stefan Agner wrote:
> From: Stefan Agner <stefan.agner at toradex.com>
> 
> Add a new command to start USB Serial Download Protocol (SDP)
> state machine.
> 
> Signed-off-by: Stefan Agner <stefan.agner at toradex.com>
> ---
> 
>  cmd/Kconfig          |  7 +++++++
>  cmd/Makefile         |  1 +
>  cmd/usb_gadget_sdp.c | 53 ++++++++++++++++++++++++++++++++++++++++++++++++++++
>  3 files changed, 61 insertions(+)
>  create mode 100644 cmd/usb_gadget_sdp.c
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index f18efc1e88..87333b3a97 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -665,6 +665,13 @@ config CMD_DFU
>  	  Enables the command "dfu" which is used to have U-Boot create a DFU
>  	  class device via USB.
>  
> +config CMD_USB_SDP
> +	bool "sdp"
> +	select USB_FUNCTION_SDP
> +	help
> +	  Enables the command "sdp" which is used to have U-Boot emulating the
> +	  Serial Download Protocol (SDP) via USB.
> +
>  config CMD_USB_MASS_STORAGE
>  	bool "UMS usb mass storage"
>  	help
> diff --git a/cmd/Makefile b/cmd/Makefile
> index bd231f24d8..e0b5940ba6 100644
> --- a/cmd/Makefile
> +++ b/cmd/Makefile
> @@ -131,6 +131,7 @@ obj-$(CONFIG_CMD_FASTBOOT) += fastboot.o
>  obj-$(CONFIG_CMD_FS_UUID) += fs_uuid.o
>  
>  obj-$(CONFIG_CMD_USB_MASS_STORAGE) += usb_mass_storage.o
> +obj-$(CONFIG_CMD_USB_SDP) += usb_gadget_sdp.o
>  obj-$(CONFIG_CMD_THOR_DOWNLOAD) += thordown.o
>  obj-$(CONFIG_CMD_XIMG) += ximg.o
>  obj-$(CONFIG_YAFFS2) += yaffs2.o
> diff --git a/cmd/usb_gadget_sdp.c b/cmd/usb_gadget_sdp.c
> new file mode 100644
> index 0000000000..09ddb4f3aa
> --- /dev/null
> +++ b/cmd/usb_gadget_sdp.c
> @@ -0,0 +1,53 @@
> +/*
> + * cmd_sdp.c -- sdp command
> + *
> + * Copyright (C) 2016 Toradex
> + * Author: Stefan Agner <stefan.agner at toradex.com>
> + *
> + * SPDX-License-Identifier:	GPL-2.0+
> + */
> +
> +#include <common.h>
> +#include <g_dnl.h>
> +#include <sdp.h>
> +#include <usb.h>
> +
> +static int do_sdp(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
> +{
> +	int ret = CMD_RET_SUCCESS;
> +
> +	if (argc < 2)
> +		return CMD_RET_USAGE;
> +
> +	char *usb_controller = argv[1];
> +	int controller_index = simple_strtoul(usb_controller, NULL, 0);
> +	board_usb_init(controller_index, USB_INIT_DEVICE);
> +
> +	g_dnl_clear_detach();
> +	g_dnl_register("usb_dnl_sdp");
> +
> +	ret = sdp_init();
> +	if (ret) {
> +		error("SDP init failed: %d", ret);
> +		ret = CMD_RET_FAILURE;
> +		goto exit;
> +	}
> +
> +	ret = sdp_handle();
> +	if (ret) {
> +		error("SDP failed: %d", ret);
> +		ret = CMD_RET_FAILURE;
> +		goto exit;
> +	}
> +
> +exit:
> +	g_dnl_unregister();
> +
> +	return ret;
> +}
> +
> +U_BOOT_CMD(sdp, 2, 1, do_sdp,
> +	"Serial Downloader Protocol",
> +	"<USB_controller>\n"
> +	"  - serial downloader protocol via <USB_controller>\n"
> +);
> 

Reviewed-by: Stefano Babic <sbabic at denx.de>

Best regards,
Stefano Babic


-- 
=====================================================================
DENX Software Engineering GmbH,      Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic at denx.de
=====================================================================