[U-Boot] [PATCH 0/8] fs/fat: cleanups + readdir implementation

Heinrich Schuchardt xypron.debian at gmx.de
Sun Aug 13 11:28:19 UTC 2017


On 08/13/2017 12:45 PM, Rob Clark wrote:
> Introduce directory traversal iterators, and implement fs_readdir()
> which is needed by EFI_LOADER.
> 
> The part re-working fat.c to use the directory iterators itself is
> nearly a 2:1 negative diffstat, and a pretty big cleanup.  I fixed
> one or two other small issues along the way.  It hasn't really been
> tested with a wide variaty of different fat filesystems (if someone
> has a collection of disk images to test with somewhere, let me know),
> but it seems at least not worse than what it is replacing.
> 
> Rob Clark (8):
>   fs/fat: split out helper to init fsdata
>   fs/fat: introduce new director iterators
>   fat/fs: convert to directory iterators
>   fs: add fs_readdir()
>   fs/fat: implement opendir/readdir/closedir
>   fat/fs: remove a bunch of dead code
>   fat/fs: move ls to generic implementation
>   fs/fat: fix case for FAT shortnames
> 
>  fs/fat/Makefile    |    4 -
>  fs/fat/fat.c       | 1019 +++++++++++++++++++++-------------------------------
>  fs/fat/fat_write.c |    4 +-
>  fs/fat/file.c      |  183 ----------
>  fs/fs.c            |  119 +++++-
>  include/fat.h      |   35 +-
>  include/fs.h       |   55 +++
>  7 files changed, 590 insertions(+), 829 deletions(-)
>  delete mode 100644 fs/fat/file.c
> 
Hello Rob,

I assume this patch series is meant to be merged before
[PATCH v1 00/15] enough UEFI for standard distro boot
and partially replaces it. Did I get it right?

Regards

Heinrich


More information about the U-Boot mailing list