[U-Boot] [PATCH 0/8] fs/fat: cleanups + readdir implementation

Rob Clark robdclark at gmail.com
Sun Aug 13 21:50:39 UTC 2017


On Sun, Aug 13, 2017 at 5:13 PM, Tom Rini <trini at konsulko.com> wrote:
> On Sun, Aug 13, 2017 at 06:45:20AM -0400, Rob Clark wrote:
>
>> Introduce directory traversal iterators, and implement fs_readdir()
>> which is needed by EFI_LOADER.
>>
>> The part re-working fat.c to use the directory iterators itself is
>> nearly a 2:1 negative diffstat, and a pretty big cleanup.  I fixed
>> one or two other small issues along the way.  It hasn't really been
>> tested with a wide variaty of different fat filesystems (if someone
>> has a collection of disk images to test with somewhere, let me know),
>> but it seems at least not worse than what it is replacing.
>
> Did you run test/fs/fs-test.sh and confirm there's at least no
> regressions?  Thanks!

I've been having trouble getting fs-test.sh to pass even without my
changes, so no..

Not entirely sure if I have newer kernel/etc compared to the last
person who ran fs-test.sh, or if there is something on u-boot side
which changed without corresponding change in fs-test.sh.

BR,
-R


More information about the U-Boot mailing list