[U-Boot] [U-Boot, RFC, 1/1] omap3: incorrect logical check in do_emif4_init

Tom Rini trini at konsulko.com
Mon Aug 14 00:06:42 UTC 2017


On Sat, Apr 15, 2017 at 04:11:12PM +0200, xypron.glpk at gmx.de wrote:

> ((readl(&emif4_base->sdram_iodft_tlgc) & (1<<10)) == 0x01)
> is always false.
> This does not match the comment
> /*Wait till that bit clears*/
> 
> The problem was indicated by cppcheck.
> 
> I do not have the hardware to test if the code change below
> leads to a correct system behavior.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk at gmx.de>
> Reviewed-by: Simon Glass <sjg at chromium.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20170813/938c3209/attachment.sig>


More information about the U-Boot mailing list